Bug 208148 - spinRunLoop should take a non-zero integer as parameter
Summary: spinRunLoop should take a non-zero integer as parameter
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sihui Liu
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-02-24 11:28 PST by Sihui Liu
Modified: 2020-02-25 10:37 PST (History)
5 users (show)

See Also:

Attachments
Patch (2.86 KB, patch)
2020-02-24 11:30 PST, Sihui Liu 		no flags Details | Formatted Diff | Diff
Patch for landing (1.20 KB, patch)
2020-02-25 09:53 PST, Sihui Liu 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sihui Liu 2020-02-24 11:28:53 PST 
spinRunLoop(0.1) does not run the runloop.
Comment 1 Sihui Liu 2020-02-24 11:30:10 PST 
Created attachment 391561 [details]
Patch
Comment 2 Sihui Liu 2020-02-25 08:51:45 PST 
The layout test failure on ios-wk2 is not caused by this patch for sure.
Comment 3 WebKit Commit Bot 2020-02-25 09:20:03 PST 
Comment on attachment 391561 [details]
Patch

Clearing flags on attachment: 391561

Committed r257359: <https://trac.webkit.org/changeset/257359>
Comment 4 WebKit Commit Bot 2020-02-25 09:20:04 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2020-02-25 09:21:15 PST 
<rdar://problem/59766682>
Comment 6 Sihui Liu 2020-02-25 09:53:32 PST 
Reopening to attach new patch.
Comment 7 Sihui Liu 2020-02-25 09:53:33 PST 
Created attachment 391664 [details]
Patch for landing
Comment 8 WebKit Commit Bot 2020-02-25 10:37:30 PST 
Comment on attachment 391664 [details]
Patch for landing

Clearing flags on attachment: 391664

Committed r257362: <https://trac.webkit.org/changeset/257362>
Comment 9 WebKit Commit Bot 2020-02-25 10:37:31 PST 
All reviewed patches have been landed.  Closing bug.