Bug 207897 - [iOS] Use one telemetry decoration for each sandbox rule
Summary: [iOS] Use one telemetry decoration for each sandbox rule
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-02-18 10:38 PST by Per Arne Vollan
Modified: 2020-02-24 15:19 PST (History)
3 users (show)

See Also:

Attachments
Patch (2.99 KB, patch)
2020-02-18 10:40 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2020-02-18 10:38:15 PST 
Currently, we are using the decorations '(with telemetry)' and '(with telemetry-backtrace)' for some sandbox rules in the WebContent process' sandbox. Only one of the two decorations should be used.
Comment 1 Per Arne Vollan 2020-02-18 10:40:58 PST 
Created attachment 391065 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2020-02-18 10:41:44 PST 
<rdar://problem/59556086>
Comment 3 Brent Fulgham 2020-02-24 13:17:20 PST 
Comment on attachment 391065 [details]
Patch

r=me
Comment 4 Per Arne Vollan 2020-02-24 13:37:33 PST 
Comment on attachment 391065 [details]
Patch

Thanks for reviewing!
Comment 5 WebKit Commit Bot 2020-02-24 14:31:36 PST 
The commit-queue encountered the following flaky tests while processing attachment 391065 [details]:

http/tests/security/contentSecurityPolicy/report-status-code-zero-when-using-https.html bug 197297 (author: dbates@webkit.org)
The commit-queue is continuing to process your patch.
Comment 6 WebKit Commit Bot 2020-02-24 14:32:04 PST 
The commit-queue encountered the following flaky tests while processing attachment 391065 [details]:

editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org)
The commit-queue is continuing to process your patch.
Comment 7 WebKit Commit Bot 2020-02-24 15:03:06 PST 
The commit-queue encountered the following flaky tests while processing attachment 391065 [details]:

editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org)
The commit-queue is continuing to process your patch.
Comment 8 WebKit Commit Bot 2020-02-24 15:03:23 PST 
The commit-queue encountered the following flaky tests while processing attachment 391065 [details]:

editing/spelling/spellcheck-paste-disabled.html bug 208159 (authors: g.czajkowski@samsung.com and mark.lam@apple.com)
The commit-queue is continuing to process your patch.
Comment 9 WebKit Commit Bot 2020-02-24 15:19:04 PST 
Comment on attachment 391065 [details]
Patch

Clearing flags on attachment: 391065

Committed r257264: <https://trac.webkit.org/changeset/257264>
Comment 10 WebKit Commit Bot 2020-02-24 15:19:06 PST 
All reviewed patches have been landed.  Closing bug.