Bug 207713 - Ensure animations that lose their effect don't schedule an animation update
Summary: Ensure animations that lose their effect don't schedule an animation update
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-02-13 12:05 PST by Sunny He
Modified: 2020-02-14 10:29 PST (History)
5 users (show)

See Also:


Attachments
Patch (3.98 KB, patch)
2020-02-13 12:08 PST, Sunny He
no flags Details | Formatted Diff | Diff
Patch (4.99 KB, patch)
2020-02-14 09:08 PST, Sunny He
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sunny He 2020-02-13 12:05:58 PST
rdar://59174840
Comment 1 Sunny He 2020-02-13 12:08:15 PST
Created attachment 390675 [details]
Patch
Comment 2 Antoine Quint 2020-02-14 07:49:19 PST
Comment on attachment 390675 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390675&action=review

> Source/WebCore/ChangeLog:3
> +        Fix handling of animations which lose their effect

I would suggest this bug is renamed "Ensure animations that lose their effect don't schedule an animation update". It's more descriptive of the issue that is fixed.

> Source/WebCore/ChangeLog:7
> +

You need a description for what your patch does. Something like "An active animation for which the effect is removed may be considered for an upcoming animation resolution. However, WebAnimation::timeToNextTick() expects a valid effect to be available to be able to determine timing. We now check an animation is relevant before calling timeToNextTick() and add an ASSERT() in that function to catch cases where an animation effect might not be available."

> Source/WebCore/ChangeLog:8
> +        Test: fast/animation/animation-null-effect.html

I would file this under LayoutTests/webanimations with other Web Animations tests. The fast/animation directory only contains CSS-based animations tests.
Comment 3 Sunny He 2020-02-14 09:08:23 PST
Created attachment 390774 [details]
Patch
Comment 4 WebKit Commit Bot 2020-02-14 10:29:52 PST
Comment on attachment 390774 [details]
Patch

Clearing flags on attachment: 390774

Committed r256623: <https://trac.webkit.org/changeset/256623>
Comment 5 WebKit Commit Bot 2020-02-14 10:29:53 PST
All reviewed patches have been landed.  Closing bug.