RESOLVED FIXED 207646
results.webkit.org: Link to result archives 
https://bugs.webkit.org/show_bug.cgi?id=207646
Summary results.webkit.org: Link to result archives
Jonathan Bedard
Reported 2020-02-12 10:43:43 PST
After https://bugs.webkit.org/show_bug.cgi?id=207589, our result archives will be performant enough to link to.
Attachments
Patch (17.14 KB, patch)
2020-02-12 12:12 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch for landing (17.19 KB, patch)
2020-02-24 10:13 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-02-12 11:57:18 PST
<rdar://problem/59395807>
Jonathan Bedard
Comment 2 2020-02-12 12:12:24 PST
Created attachment 390543 [details] Patch
Zhifei Fang
Comment 3 2020-02-13 11:09:36 PST
I just have one high level comment, this seems very specific for archives, maybe we should consider a general suite config and make the archive router part of it? It will be easier to expand when we have more configs.
Jonathan Bedard
Comment 4 2020-02-13 12:55:06 PST
(In reply to Zhifei Fang from comment #3) > I just have one high level comment, this seems very specific for archives, > maybe we should consider a general suite config and make the archive router > part of it? It will be easier to expand when we have more configs. It is very specific to archives because nothing else actually requires configurations. I could see configurations about which queues are collapsed by default, but we don't have a mechanism for that yet.
Zhifei Fang
Comment 5 2020-02-13 13:14:30 PST
unofficially r=me
Zhifei Fang
Comment 6 2020-02-13 13:15:29 PST
I don't think this will block this patch, we can develop one when we need (In reply to Jonathan Bedard from comment #4) > (In reply to Zhifei Fang from comment #3) > > I just have one high level comment, this seems very specific for archives, > > maybe we should consider a general suite config and make the archive router > > part of it? It will be easier to expand when we have more configs. > > It is very specific to archives because nothing else actually requires > configurations. > > I could see configurations about which queues are collapsed by default, but > we don't have a mechanism for that yet.
Aakash Jain
Comment 7 2020-02-24 09:31:38 PST
Comment on attachment 390543 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390543&action=review rs=me > Tools/ChangeLog:3 > + results.webki.org: Link to result archives typo: webki.org
Jonathan Bedard
Comment 8 2020-02-24 10:13:03 PST
Created attachment 391552 [details] Patch for landing
WebKit Commit Bot
Comment 9 2020-02-24 10:57:36 PST
Comment on attachment 391552 [details] Patch for landing Clearing flags on attachment: 391552 Committed r257219: <https://trac.webkit.org/changeset/257219>
WebKit Commit Bot
Comment 10 2020-02-24 10:57:37 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.