Bug 207448 - Web Inspector: encode binary web socket frames using base64
Summary: Web Inspector: encode binary web socket frames using base64
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-02-09 18:10 PST by Pavel Feldman
Modified: 2020-02-12 18:19 PST (History)
15 users (show)

See Also:


Attachments
Patch (10.04 KB, patch)
2020-02-09 18:23 PST, Pavel Feldman
no flags Details | Formatted Diff | Diff
Patch (10.02 KB, patch)
2020-02-09 20:22 PST, Pavel Feldman
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2020-02-09 18:10:41 PST
Current representation of binary frames is lossy using fromUTF8WithLatin1Fallback, we should consistently encode binary data using base64 instead.
Comment 1 Pavel Feldman 2020-02-09 18:23:55 PST
Created attachment 390221 [details]
Patch
Comment 2 Build Bot 2020-02-09 18:24:31 PST
This patch modifies the inspector protocol. Please ensure that any frontend changes appropriately use feature checks for new protocol features.
Comment 3 Pavel Feldman 2020-02-09 20:22:57 PST
Created attachment 390227 [details]
Patch
Comment 4 ews-feeder 2020-02-12 17:20:19 PST
Comment on attachment 390227 [details]
Patch

Rejecting attachment 390227 [details] from commit-queue.

pfeldman@chromium.org does not have committer permissions according to https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.
Comment 5 WebKit Commit Bot 2020-02-12 18:17:54 PST
The commit-queue encountered the following flaky tests while processing attachment 390227 [details]:

editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org)
imported/w3c/web-platform-tests/content-security-policy/script-src/scriptnonce-changed-1.html bug 206029 (author: psaavedra@igalia.com)
The commit-queue is continuing to process your patch.
Comment 6 WebKit Commit Bot 2020-02-12 18:18:33 PST
Comment on attachment 390227 [details]
Patch

Clearing flags on attachment: 390227

Committed r256497: <https://trac.webkit.org/changeset/256497>
Comment 7 WebKit Commit Bot 2020-02-12 18:18:35 PST
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2020-02-12 18:19:21 PST
<rdar://problem/59409791>