Bug 207186 - Adopt new SOAuthorizationOption constants
Summary: Adopt new SOAuthorizationOption constants
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jiewen Tan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-02-03 22:50 PST by Jiewen Tan
Modified: 2020-02-06 18:38 PST (History)
4 users (show)

See Also:

Attachments
Patch (7.51 KB, patch)
2020-02-03 22:56 PST, Jiewen Tan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jiewen Tan 2020-02-03 22:50:04 PST 
Adopt new SOAuthorizationOption constants.
Comment 1 Jiewen Tan 2020-02-03 22:50:23 PST 
<rdar://problem/48909336>
Comment 2 Jiewen Tan 2020-02-03 22:56:07 PST 
Created attachment 389634 [details]
Patch
Comment 3 Brent Fulgham 2020-02-06 17:31:11 PST 
Comment on attachment 389634 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=389634&action=review

r=me

> Source/WebKit/UIProcess/Cocoa/SOAuthorization/SOAuthorizationSession.mm:-172
> -    // FIXME: <rdar://problem/48909336> Replace the below with AppSSO constants.

At last!
Comment 4 Jiewen Tan 2020-02-06 17:38:32 PST 
Comment on attachment 389634 [details]
Patch

Thanks for r+ this patch.
Comment 5 WebKit Commit Bot 2020-02-06 18:38:26 PST 
Comment on attachment 389634 [details]
Patch

Clearing flags on attachment: 389634

Committed r255999: <https://trac.webkit.org/changeset/255999>
Comment 6 WebKit Commit Bot 2020-02-06 18:38:27 PST 
All reviewed patches have been landed.  Closing bug.