WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
207186
Adopt new SOAuthorizationOption constants
https://bugs.webkit.org/show_bug.cgi?id=207186
Summary
Adopt new SOAuthorizationOption constants
Jiewen Tan
Reported
2020-02-03 22:50:04 PST
Adopt new SOAuthorizationOption constants.
Attachments
Patch
(7.51 KB, patch)
2020-02-03 22:56 PST
,
Jiewen Tan
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Jiewen Tan
Comment 1
2020-02-03 22:50:23 PST
<
rdar://problem/48909336
>
Jiewen Tan
Comment 2
2020-02-03 22:56:07 PST
Created
attachment 389634
[details]
Patch
Brent Fulgham
Comment 3
2020-02-06 17:31:11 PST
Comment on
attachment 389634
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=389634&action=review
r=me
> Source/WebKit/UIProcess/Cocoa/SOAuthorization/SOAuthorizationSession.mm:-172 > - // FIXME: <
rdar://problem/48909336
> Replace the below with AppSSO constants.
At last!
Jiewen Tan
Comment 4
2020-02-06 17:38:32 PST
Comment on
attachment 389634
[details]
Patch Thanks for r+ this patch.
WebKit Commit Bot
Comment 5
2020-02-06 18:38:26 PST
Comment on
attachment 389634
[details]
Patch Clearing flags on attachment: 389634 Committed
r255999
: <
https://trac.webkit.org/changeset/255999
>
WebKit Commit Bot
Comment 6
2020-02-06 18:38:27 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug