Bug 207108 - Make sure RTCVideoEncoderH264 generate a keyframe even if the frame that was supposed to be a key frame was dropped
Summary: Make sure RTCVideoEncoderH264 generate a keyframe even if the frame that was ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-02-02 23:40 PST by youenn fablet
Modified: 2020-02-03 08:39 PST (History)
9 users (show)

See Also:


Attachments
Patch (6.56 KB, patch)
2020-02-02 23:43 PST, youenn fablet
no flags Details | Formatted Diff | Diff
Patch (6.93 KB, patch)
2020-02-03 00:15 PST, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2020-02-02 23:40:43 PST
Make sure RTCVideoEncoderH264 generate a keyframe even if the frame that was supposed to be a key frame was dropped
Comment 1 youenn fablet 2020-02-02 23:43:34 PST
Created attachment 389491 [details]
Patch
Comment 2 youenn fablet 2020-02-03 00:15:24 PST
Created attachment 389492 [details]
Patch
Comment 3 WebKit Commit Bot 2020-02-03 08:37:58 PST
The commit-queue encountered the following flaky tests while processing attachment 389492 [details]:

editing/spelling/spellcheck-attribute.html bug 206178 (authors: g.czajkowski@samsung.com, mark.lam@apple.com, and rniwa@webkit.org)
The commit-queue is continuing to process your patch.
Comment 4 WebKit Commit Bot 2020-02-03 08:38:35 PST
Comment on attachment 389492 [details]
Patch

Clearing flags on attachment: 389492

Committed r255564: <https://trac.webkit.org/changeset/255564>
Comment 5 WebKit Commit Bot 2020-02-03 08:38:36 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2020-02-03 08:39:16 PST
<rdar://problem/59111507>