Bug 207085 - [JSC] ShrinkToFit some vectors kept by JIT data structures
Summary: [JSC] ShrinkToFit some vectors kept by JIT data structures
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-31 20:38 PST by Yusuke Suzuki
Modified: 2020-01-31 21:23 PST (History)
7 users (show)

See Also:

Attachments
Patch (12.88 KB, patch)
2020-01-31 20:41 PST, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (12.89 KB, patch)
2020-01-31 20:47 PST, Yusuke Suzuki 		mark.lam: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2020-01-31 20:38:21 PST 
[JSC] ShrinkToFit some vectors kept by JIT data structures
Comment 1 Yusuke Suzuki 2020-01-31 20:41:38 PST 
Created attachment 389451 [details]
Patch
Comment 2 Yusuke Suzuki 2020-01-31 20:47:05 PST 
Created attachment 389452 [details]
Patch
Comment 3 Mark Lam 2020-01-31 21:01:29 PST 
Comment on attachment 389452 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=389452&action=review

r=me

> Source/JavaScriptCore/jit/JIT.cpp:242
> +        unsigned slowCasesBefore = m_slowCases.size();

Let’s call this previousSlowCasesSize.
Comment 4 Yusuke Suzuki 2020-01-31 21:22:04 PST 
Comment on attachment 389452 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=389452&action=review

>> Source/JavaScriptCore/jit/JIT.cpp:242
>> +        unsigned slowCasesBefore = m_slowCases.size();
> 
> Let’s call this previousSlowCasesSize.

Sounds nice, fixed.
Comment 5 Yusuke Suzuki 2020-01-31 21:22:53 PST 
Committed r255541: <https://trac.webkit.org/changeset/255541>
Comment 6 Radar WebKit Bug Importer 2020-01-31 21:23:16 PST 
<rdar://problem/59084513>