Bug 207083 - [JSC] DFG::CommonData::shrinkToFit called before DFG::Plan::reallyAdd is called
Summary: [JSC] DFG::CommonData::shrinkToFit called before DFG::Plan::reallyAdd is called
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-31 18:16 PST by Yusuke Suzuki
Modified: 2020-01-31 19:37 PST (History)
8 users (show)

See Also:


Attachments
Patch (6.52 KB, patch)
2020-01-31 19:27 PST, Yusuke Suzuki
mark.lam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2020-01-31 18:16:29 PST
DFG::Plan::reallyAdd adds a lot of entries to DFG::CommonData.
Comment 1 Yusuke Suzuki 2020-01-31 19:27:01 PST
Created attachment 389450 [details]
Patch
Comment 2 Yusuke Suzuki 2020-01-31 19:27:51 PST
Simon's Vector capacity tracking patch reveals this :)
Comment 3 Mark Lam 2020-01-31 19:34:23 PST
Comment on attachment 389450 [details]
Patch

r=me
Comment 4 Yusuke Suzuki 2020-01-31 19:36:47 PST
Committed r255540: <https://trac.webkit.org/changeset/255540>
Comment 5 Radar WebKit Bug Importer 2020-01-31 19:37:41 PST
<rdar://problem/59083683>