Bug 207037 - Compilation broken without service workers
Summary: Compilation broken without service workers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alejandro G. Castro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-31 03:36 PST by Alejandro G. Castro
Modified: 2020-01-31 08:39 PST (History)
3 users (show)

See Also:

Attachments
Patch (1.43 KB, patch)
2020-01-31 03:39 PST, Alejandro G. Castro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alejandro G. Castro 2020-01-31 03:36:26 PST 
The commit added some code that depends on variables defined inside SERVICE_WORKER. Not sure if there is something else in the patch we should protect even if it compiles just avoiding the m_swServers.
Comment 1 Alejandro G. Castro 2020-01-31 03:39:43 PST 
Created attachment 389340 [details]
Patch
Comment 2 WebKit Commit Bot 2020-01-31 08:38:34 PST 
Comment on attachment 389340 [details]
Patch

Clearing flags on attachment: 389340

Committed r255498: <https://trac.webkit.org/changeset/255498>
Comment 3 WebKit Commit Bot 2020-01-31 08:38:36 PST 
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2020-01-31 08:39:15 PST 
<rdar://problem/59062666>