Bug 206920 - Web Inspector: Some cookie table column headers should not be localizable
Summary: Web Inspector: Some cookie table column headers should not be localizable
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nikita Vasilyev
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-28 23:00 PST by Nikita Vasilyev
Modified: 2020-02-05 19:36 PST (History)
4 users (show)

See Also:

Attachments
Patch (2.76 KB, patch)
2020-01-28 23:04 PST, Nikita Vasilyev 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Vasilyev 2020-01-28 23:00:19 PST 
Some of the localized headers should always be in English because they match cookie directives.
Only "Name", "Value", and "Size" should be localized.

https://github.com/WebKit/webkit/blob/2764480713d1f2b46b8f239eae5a99a6fcc3b6d9/Source/WebInspectorUI/UserInterface/Views/CookieStorageContentView.js#L169-L225

<rdar://57857579>
Comment 1 Nikita Vasilyev 2020-01-28 23:04:25 PST 
Created attachment 389107 [details]
Patch
Comment 2 WebKit Commit Bot 2020-02-05 18:46:33 PST 
The commit-queue encountered the following flaky tests while processing attachment 389107 [details]:

editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org)
The commit-queue is continuing to process your patch.
Comment 3 WebKit Commit Bot 2020-02-05 18:46:55 PST 
The commit-queue encountered the following flaky tests while processing attachment 389107 [details]:

editing/spelling/spellcheck-attribute.html bug 206178 (authors: g.czajkowski@samsung.com, mark.lam@apple.com, and rniwa@webkit.org)
The commit-queue is continuing to process your patch.
Comment 4 WebKit Commit Bot 2020-02-05 19:36:08 PST 
Comment on attachment 389107 [details]
Patch

Clearing flags on attachment: 389107

Committed r255896: <https://trac.webkit.org/changeset/255896>
Comment 5 WebKit Commit Bot 2020-02-05 19:36:10 PST 
All reviewed patches have been landed.  Closing bug.