RESOLVED FIXED 206833
Tools/Scripts/set-webkit-configuration should accept --coverage/--no-coverage 
https://bugs.webkit.org/show_bug.cgi?id=206833
Summary Tools/Scripts/set-webkit-configuration should accept --coverage/--no-coverage
Robin Morisset
Reported 2020-01-27 10:14:08 PST
https://bugs.webkit.org/show_bug.cgi?id=206389 introduced two options in Tools/Scripts/set-webkit-configuration, but did not adapt the check that at least one valid option is passed. So the following works: set-webkit-configuration --no-asan --no-coverage But the following is rejected: set-webkit-configuration --no-asan. The fix should be trivial.
Attachments
Patch (1.32 KB, patch)
2020-01-27 10:24 PST, Robin Morisset 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Robin Morisset
Comment 1 2020-01-27 10:24:15 PST
Created attachment 388872 [details] Patch
Tuomas Karkkainen
Comment 2 2020-01-27 10:25:40 PST
looks good. thank you!
WebKit Commit Bot
Comment 3 2020-01-27 12:18:49 PST
Comment on attachment 388872 [details] Patch Clearing flags on attachment: 388872 Committed r255160: <https://trac.webkit.org/changeset/255160>
WebKit Commit Bot
Comment 4 2020-01-27 12:18:51 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2020-01-27 12:19:16 PST
<rdar://problem/58929211>
Note You need to log in before you can comment on or make changes to this bug.