Bug 206833 - Tools/Scripts/set-webkit-configuration should accept --coverage/--no-coverage
Summary: Tools/Scripts/set-webkit-configuration should accept --coverage/--no-coverage
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Robin Morisset
URL:
Keywords: InRadar
Depends on: 206389
Blocks:
  Show dependency tree / graph
 
Reported: 2020-01-27 10:14 PST by Robin Morisset
Modified: 2020-01-31 11:31 PST (History)
5 users (show)

See Also:

Attachments
Patch (1.32 KB, patch)
2020-01-27 10:24 PST, Robin Morisset 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robin Morisset 2020-01-27 10:14:08 PST 
https://bugs.webkit.org/show_bug.cgi?id=206389 introduced two options in Tools/Scripts/set-webkit-configuration, but did not adapt the check that at least one valid option is passed.
So the following works: set-webkit-configuration --no-asan --no-coverage
But the following is rejected: set-webkit-configuration --no-asan.

The fix should be trivial.
Comment 1 Robin Morisset 2020-01-27 10:24:15 PST 
Created attachment 388872 [details]
Patch
Comment 2 Tuomas Karkkainen 2020-01-27 10:25:40 PST 
looks good. thank you!
Comment 3 WebKit Commit Bot 2020-01-27 12:18:49 PST 
Comment on attachment 388872 [details]
Patch

Clearing flags on attachment: 388872

Committed r255160: <https://trac.webkit.org/changeset/255160>
Comment 4 WebKit Commit Bot 2020-01-27 12:18:51 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2020-01-27 12:19:16 PST 
<rdar://problem/58929211>