Bug 20670 - Need more USE(JSC) wrappers to build Chromium from ToT WebKit
Summary: Need more USE(JSC) wrappers to build Chromium from ToT WebKit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-09-05 11:12 PDT by Eric Seidel (no email)
Modified: 2008-09-05 15:18 PDT (History)
1 user (show)

See Also:


Attachments
patch, will add changelog before landing (4.26 KB, patch)
2008-09-05 14:42 PDT, Eric Seidel (no email)
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2008-09-05 11:12:45 PDT
Attached patch makes things build (or nearly)
Comment 1 Eric Seidel (no email) 2008-09-05 14:42:07 PDT
Created attachment 23201 [details]
patch, will add changelog before landing
Comment 2 Darin Adler 2008-09-05 14:48:20 PDT
Comment on attachment 23201 [details]
patch, will add changelog before landing

The Image.h, FileSystem.h, RenderStyle.h, and CompositeAnimation.h changes seems to be unrelated.

+#if USE(JSC)
     PassRefPtr<Element> querySelector(const String& selectors, NSResolver*, ExceptionCode&, KJS::ExecState*);
     PassRefPtr<NodeList> querySelectorAll(const String& selectors, NSResolver*, ExceptionCode&, KJS::ExecState*);
+#endif

This ifdef is backwards. In my opinion we're leaving this out when using V8 because V8 doesn't have it implemented, so it should be #if !USE(V8).

But despite these quibbles I guess it's OK to land as-is.
Comment 3 Eric Seidel (no email) 2008-09-05 14:50:45 PDT
(In reply to comment #2)
> (From update of attachment 23201 [details] [edit])
> The Image.h, FileSystem.h, RenderStyle.h, and CompositeAnimation.h changes
> seems to be unrelated.
> 
> +#if USE(JSC)
>      PassRefPtr<Element> querySelector(const String& selectors, NSResolver*,
> ExceptionCode&, KJS::ExecState*);
>      PassRefPtr<NodeList> querySelectorAll(const String& selectors,
> NSResolver*, ExceptionCode&, KJS::ExecState*);
> +#endif
> 
> This ifdef is backwards. In my opinion we're leaving this out when using V8
> because V8 doesn't have it implemented, so it should be #if !USE(V8).
> 
> But despite these quibbles I guess it's OK to land as-is.

I used #if USE(JSC) because those lines are only applicable when you have the JSC types.  it has to do with KJS::ExecState* and nothing to do with the methods themselves.

-eric
Comment 4 Darin Adler 2008-09-05 14:58:16 PDT
(In reply to comment #3)
> I used #if USE(JSC) because those lines are only applicable when you have the
> JSC types. it has to do with KJS::ExecState* and nothing to do with the
> methods themselves.

Oh, that's right. Sorry, I missed that.
Comment 5 Eric Seidel (no email) 2008-09-05 15:18:18 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/dom/Node.h
	M	WebCore/page/Console.h
	M	WebCore/page/animation/CompositeAnimation.h
	M	WebCore/platform/FileSystem.h
	M	WebCore/platform/graphics/Image.h
	M	WebCore/platform/text/AtomicString.h
	M	WebCore/platform/text/String.cpp
	M	WebCore/rendering/style/RenderStyle.h
Committed r36120