RESOLVED FIXED206507
[LFC][IFC] InlineFormattingContext::lineLayout should take a InlineItem range 
https://bugs.webkit.org/show_bug.cgi?id=206507
Summary [LFC][IFC] InlineFormattingContext::lineLayout should take a InlineItem range
alan
Reported 2020-01-20 11:49:19 PST
instead of going from 0 to InlineItemList.size()
Attachments
Patch (20.05 KB, patch)
2020-01-20 12:18 PST, alan 		no flags
DetailsFormatted DiffDiff
Patch (21.90 KB, patch)
2020-01-20 12:55 PST, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-01-20 11:49:55 PST
<rdar://problem/58742468>
alan
Comment 2 2020-01-20 12:18:46 PST
Created attachment 388249 [details] Patch
Antti Koivisto
Comment 3 2020-01-20 12:20:39 PST
Comment on attachment 388249 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=388249&action=review > Source/WebCore/layout/inlineformatting/LineLayoutContext.h:54 > + bool isEmpty() const { return start >= end; } Why would start > end?
alan
Comment 4 2020-01-20 12:37:35 PST
(In reply to Antti Koivisto from comment #3) > Comment on attachment 388249 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=388249&action=review > > > Source/WebCore/layout/inlineformatting/LineLayoutContext.h:54 > > + bool isEmpty() const { return start >= end; } > > Why would start > end? indeed why would.
alan
Comment 5 2020-01-20 12:55:59 PST
Created attachment 388251 [details] Patch
WebKit Commit Bot
Comment 6 2020-01-20 15:32:56 PST
Comment on attachment 388251 [details] Patch Clearing flags on attachment: 388251 Committed r254837: <https://trac.webkit.org/changeset/254837>
WebKit Commit Bot
Comment 7 2020-01-20 15:32:57 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.