Bug 206475 - Make isValidUserAgentHeaderValue GLib only
Summary: Make isValidUserAgentHeaderValue GLib only
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Rob Buis
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-18 11:30 PST by Rob Buis
Modified: 2020-01-20 03:00 PST (History)
3 users (show)

See Also:

Attachments
Patch (3.95 KB, patch)
2020-01-18 11:32 PST, Rob Buis 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rob Buis 2020-01-18 11:30:09 PST 
The function isValidUserAgentHeaderValue is only used by code that requires GLib, so move it behind USE(GLIB).
Comment 1 Rob Buis 2020-01-18 11:32:43 PST 
Created attachment 388158 [details]
Patch
Comment 2 WebKit Commit Bot 2020-01-20 02:58:41 PST 
The commit-queue encountered the following flaky tests while processing attachment 388158 [details]:

editing/spelling/spellcheck-attribute.html bug 206178 (authors: g.czajkowski@samsung.com, mark.lam@apple.com, and rniwa@webkit.org)
The commit-queue is continuing to process your patch.
Comment 3 WebKit Commit Bot 2020-01-20 02:59:13 PST 
Comment on attachment 388158 [details]
Patch

Clearing flags on attachment: 388158

Committed r254818: <https://trac.webkit.org/changeset/254818>
Comment 4 WebKit Commit Bot 2020-01-20 02:59:15 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2020-01-20 03:00:30 PST 
<rdar://problem/58734822>