Bug 206184 - Web Inspector: "Enable Local Override" and "Delete Local Override" are displayed twice in the contextual menu
Summary: Web Inspector: "Enable Local Override" and "Delete Local Override" are displa...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Local Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-13 11:04 PST by Devin Rousso
Modified: 2020-01-13 19:44 PST (History)
5 users (show)

See Also:


Attachments
Patch (3.03 KB, patch)
2020-01-13 11:06 PST, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2020-01-13 11:04:52 PST
.
Comment 1 Devin Rousso 2020-01-13 11:05:02 PST
<rdar://problem/58409880>
Comment 2 Devin Rousso 2020-01-13 11:06:33 PST
Created attachment 387547 [details]
Patch
Comment 3 Brian Burg 2020-01-13 11:45:01 PST
Comment on attachment 387547 [details]
Patch

r=me

Kind of weird, but I guess it's fine. I guess the other option is to type-check the represented object and not add them in the case they are overrides already.
Comment 4 WebKit Commit Bot 2020-01-13 19:44:02 PST
The commit-queue encountered the following flaky tests while processing attachment 387547 [details]:

editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org)
fast/hidpi/image-srcset-relative-svg-canvas-2x.html bug 206211 (author: yoav@yoav.ws)
The commit-queue is continuing to process your patch.
Comment 5 WebKit Commit Bot 2020-01-13 19:44:34 PST
Comment on attachment 387547 [details]
Patch

Clearing flags on attachment: 387547

Committed r254485: <https://trac.webkit.org/changeset/254485>
Comment 6 WebKit Commit Bot 2020-01-13 19:44:36 PST
All reviewed patches have been landed.  Closing bug.