Bug 205926 - [css-grid] Import grid-align-content-distribution tests to WPT folder
Summary: [css-grid] Import grid-align-content-distribution tests to WPT folder
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-08 07:28 PST by rmonteriso
Modified: 2020-01-20 01:50 PST (History)
7 users (show)

See Also:

Attachments
Patch (168.61 KB, patch)
2020-01-08 07:43 PST, rmonteriso 		no flags Details | Formatted Diff | Diff
Patch (228.73 KB, patch)
2020-01-09 01:52 PST, rmonteriso 		no flags Details | Formatted Diff | Diff
Patch (70.79 KB, patch)
2020-01-15 06:26 PST, rmonteriso 		no flags Details | Formatted Diff | Diff
Patch (71.65 KB, patch)
2020-01-15 07:03 PST, rmonteriso 		no flags Details | Formatted Diff | Diff
Patch (73.36 KB, patch)
2020-01-17 04:32 PST, rmonteriso 		no flags Details | Formatted Diff | Diff
Patch (2.59 KB, patch)
2020-01-17 05:13 PST, rmonteriso 		no flags Details | Formatted Diff | Diff
Patch (169.28 KB, patch)
2020-01-17 05:49 PST, rmonteriso 		no flags Details | Formatted Diff | Diff
Patch (175.95 KB, patch)
2020-01-19 05:51 PST, rmonteriso 		no flags Details | Formatted Diff | Diff
Show Obsolete (7) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description rmonteriso 2020-01-08 07:28:27 PST 
Following tests have been moved, as per https://github.com/web-platform-tests/wpt/pull/20110:

* grid-align-content-distribution-vertical-lr.html
* grid-align-content-distribution-vertical-rl.html
* grid-align-content-distribution.html

Their corresponding outdated tests in fast/css-grid-layout have been removed.
Comment 1 rmonteriso 2020-01-08 07:43:40 PST 
Created attachment 387105 [details]
Patch
Comment 2 rmonteriso 2020-01-09 01:52:01 PST 
Created attachment 387201 [details]
Patch
Comment 3 Javier Fernandez 2020-01-09 13:22:54 PST 
Comment on attachment 387201 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387201&action=review

> LayoutTests/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-align-content-distribution-expected.txt:52
> +FAIL .grid 1 assert_equals: 

These tests has some cases that fail. We should investigate it before landing.

> LayoutTests/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-align-content-distribution-vertical-lr-expected.txt:52
> +FAIL .grid 1 assert_equals: 

Ditto

> LayoutTests/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-align-content-distribution-vertical-lr.html:8
> +<link rel="stylesheet" href="/css/support/grid.css">

I think this test needs the alignment.css support file. Perhaps this is the cause of the failures mentioned before.

> LayoutTests/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-align-content-distribution-vertical-rl-expected.txt:52
> +FAIL .grid 1 assert_equals: 

Ditto

> LayoutTests/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-align-content-distribution-vertical-rl.html:8
> +<link rel="stylesheet" href="/css/support/grid.css">

Ditto

> LayoutTests/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-align-content-distribution.html:8
> +<link rel="stylesheet" href="/css/support/grid.css">

Ditto
Comment 4 rmonteriso 2020-01-15 06:26:19 PST 
Created attachment 387786 [details]
Patch
Comment 5 rmonteriso 2020-01-15 07:03:47 PST 
Created attachment 387789 [details]
Patch
Comment 6 rmonteriso 2020-01-17 04:32:38 PST 
Created attachment 388029 [details]
Patch
Comment 7 rmonteriso 2020-01-17 05:13:22 PST 
Created attachment 388030 [details]
Patch
Comment 8 rmonteriso 2020-01-17 05:49:58 PST 
Created attachment 388033 [details]
Patch
Comment 9 rmonteriso 2020-01-19 05:51:42 PST 
Created attachment 388183 [details]
Patch
Comment 10 WebKit Commit Bot 2020-01-20 01:48:54 PST 
The commit-queue encountered the following flaky tests while processing attachment 388183 [details]:

editing/spelling/spellcheck-attribute.html bug 206178 (authors: g.czajkowski@samsung.com, mark.lam@apple.com, and rniwa@webkit.org)
The commit-queue is continuing to process your patch.
Comment 11 WebKit Commit Bot 2020-01-20 01:49:40 PST 
Comment on attachment 388183 [details]
Patch

Clearing flags on attachment: 388183

Committed r254816: <https://trac.webkit.org/changeset/254816>
Comment 12 WebKit Commit Bot 2020-01-20 01:49:41 PST 
All reviewed patches have been landed.  Closing bug.
Comment 13 Radar WebKit Bug Importer 2020-01-20 01:50:20 PST 
<rdar://problem/58733525>