Bug 205710 - [LFC][IFC] Fix fast/parser/entities-in-html.html
Summary: [LFC][IFC] Fix fast/parser/entities-in-html.html
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-02 21:16 PST by zalan
Modified: 2020-01-03 07:42 PST (History)
6 users (show)

See Also:

Attachments
Patch (1.36 KB, patch)
2020-01-02 21:20 PST, zalan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2020-01-02 21:16:48 PST 
ssia
Comment 1 Radar WebKit Bug Importer 2020-01-02 21:17:16 PST 
<rdar://problem/58290731>
Comment 2 zalan 2020-01-02 21:20:49 PST 
Created attachment 386659 [details]
Patch
Comment 3 Antti Koivisto 2020-01-03 03:23:53 PST 
Comment on attachment 386659 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386659&action=review

> Source/WebCore/layout/inlineformatting/InlineTextItem.cpp:38
> -static inline bool isWhitespaceCharacter(char character, bool preserveNewline)
> +static inline bool isWhitespaceCharacter(UChar character, bool preserveNewline)

lol
Comment 4 zalan 2020-01-03 06:56:31 PST 
(In reply to Antti Koivisto from comment #3)
> Comment on attachment 386659 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=386659&action=review
> 
> > Source/WebCore/layout/inlineformatting/InlineTextItem.cpp:38
> > -static inline bool isWhitespaceCharacter(char character, bool preserveNewline)
> > +static inline bool isWhitespaceCharacter(UChar character, bool preserveNewline)
> 
> lol
exactly my thoughts.
Comment 5 WebKit Commit Bot 2020-01-03 07:42:41 PST 
Comment on attachment 386659 [details]
Patch

Clearing flags on attachment: 386659

Committed r253997: <https://trac.webkit.org/changeset/253997>
Comment 6 WebKit Commit Bot 2020-01-03 07:42:43 PST 
All reviewed patches have been landed.  Closing bug.