Bug 205385 - Missing headers in worker files cause random build failures when adding new files
Summary: Missing headers in worker files cause random build failures when adding new f...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Lord
URL:
Keywords: InRadar
Depends on:
Blocks: 202525 202574
  Show dependency tree / graph
 
Reported: 2019-12-18 03:17 PST by Chris Lord
Modified: 2019-12-18 04:08 PST (History)
7 users (show)

See Also:

Attachments
Patch (1.90 KB, patch)
2019-12-18 03:19 PST, Chris Lord 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Lord 2019-12-18 03:17:03 PST 
I've had a couple of patches hit by this - there are at least two missing headers that while cause no problems now, can cause problems when you add new files (and, I assume, change the grouping of unified sources). I'm going to deal with that separately here rather than with unrelated changes.
Comment 1 Chris Lord 2019-12-18 03:19:56 PST 
Created attachment 385952 [details]
Patch
Comment 2 WebKit Commit Bot 2019-12-18 04:07:07 PST 
Comment on attachment 385952 [details]
Patch

Clearing flags on attachment: 385952

Committed r253677: <https://trac.webkit.org/changeset/253677>
Comment 3 WebKit Commit Bot 2019-12-18 04:07:09 PST 
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2019-12-18 04:08:21 PST 
<rdar://problem/58039428>