Bug 204616 - [LFC] Don't leak Boxes
Summary: [LFC] Don't leak Boxes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-11-26 06:27 PST by Antti Koivisto
Modified: 2019-11-26 08:45 PST (History)
5 users (show)

See Also:


Attachments
patch (4.45 KB, patch)
2019-11-26 06:30 PST, Antti Koivisto
zalan: review+
Details | Formatted Diff | Diff
patch (4.45 KB, patch)
2019-11-26 08:00 PST, Antti Koivisto
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2019-11-26 06:27:23 PST
TreeBuilder is full of .release()
Comment 1 Antti Koivisto 2019-11-26 06:30:44 PST
Created attachment 384350 [details]
patch
Comment 2 zalan 2019-11-26 07:21:12 PST
Comment on attachment 384350 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384350&action=review

> Source/WebCore/layout/layouttree/LayoutTreeBuilder.cpp:284
> +    m_layoutTreeContent.addBox(WTFMove(tableBox));

Remove // Temporary ?
Comment 3 Antti Koivisto 2019-11-26 08:00:42 PST
Created attachment 384355 [details]
patch
Comment 4 WebKit Commit Bot 2019-11-26 08:44:23 PST
Comment on attachment 384355 [details]
patch

Clearing flags on attachment: 384355

Committed r252888: <https://trac.webkit.org/changeset/252888>
Comment 5 WebKit Commit Bot 2019-11-26 08:44:25 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-11-26 08:45:16 PST
<rdar://problem/57491628>