Bug 204295 - [LFC][Invalidation] Force rebuild layout tree on tree mutation
Summary: [LFC][Invalidation] Force rebuild layout tree on tree mutation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-11-18 08:08 PST by zalan
Modified: 2019-11-18 09:14 PST (History)
11 users (show)

See Also:

Attachments
Patch (3.90 KB, patch)
2019-11-18 08:11 PST, zalan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2019-11-18 08:08:21 PST 
for now.
Comment 1 Radar WebKit Bug Importer 2019-11-18 08:08:33 PST 
<rdar://problem/57283650>
Comment 2 zalan 2019-11-18 08:11:32 PST 
Created attachment 383747 [details]
Patch
Comment 3 Antti Koivisto 2019-11-18 08:19:20 PST 
Comment on attachment 383747 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383747&action=review

> Source/WebCore/rendering/updating/RenderTreeUpdater.cpp:300
> -        if (!m_document.view() || m_document.view()->layoutContext().layoutFormattingState())
> +        if (!m_document.view() || !m_document.view()->layoutContext().layoutFormattingState())

lol
Comment 4 zalan 2019-11-18 08:29:32 PST 
(In reply to Antti Koivisto from comment #3)
> Comment on attachment 383747 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=383747&action=review
> 
> > Source/WebCore/rendering/updating/RenderTreeUpdater.cpp:300
> > -        if (!m_document.view() || m_document.view()->layoutContext().layoutFormattingState())
> > +        if (!m_document.view() || !m_document.view()->layoutContext().layoutFormattingState())
> 
> lol
let's just pretend it was a typo.
Comment 5 Antti Koivisto 2019-11-18 08:30:53 PST 
> let's just pretend it was a typo.

Yeah, quietly.
Comment 6 WebKit Commit Bot 2019-11-18 09:14:57 PST 
Comment on attachment 383747 [details]
Patch

Clearing flags on attachment: 383747

Committed r252544: <https://trac.webkit.org/changeset/252544>
Comment 7 WebKit Commit Bot 2019-11-18 09:14:59 PST 
All reviewed patches have been landed.  Closing bug.