Bug 204206 - Web Inspector: Local Overrides: add context menu item to reveal the local override when a resource is loaded from it
Summary: Web Inspector: Local Overrides: add context menu item to reveal the local ove...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-11-14 15:48 PST by Devin Rousso
Modified: 2019-11-15 11:51 PST (History)
6 users (show)

See Also:


Attachments
Patch (2.87 KB, patch)
2019-11-14 15:53 PST, Devin Rousso
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews211 for win-future (14.25 MB, application/zip)
2019-11-14 19:49 PST, EWS Watchlist
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2019-11-14 15:48:44 PST
We already have a Reveal button in the content view of resources loaded from Local Overrides, but if the resource isn't selected, there's no way of jumping to it other than finding it manually in the list.
Comment 1 Devin Rousso 2019-11-14 15:53:34 PST
Created attachment 383580 [details]
Patch
Comment 2 EWS Watchlist 2019-11-14 19:49:10 PST
Comment on attachment 383580 [details]
Patch

Attachment 383580 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/13257418

New failing tests:
animations/no-style-recalc-during-accelerated-animation.html
Comment 3 EWS Watchlist 2019-11-14 19:49:12 PST
Created attachment 383597 [details]
Archive of layout-test-results from ews211 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews211  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Comment 4 Joseph Pecoraro 2019-11-15 11:23:25 PST
Comment on attachment 383580 [details]
Patch

r=me
Comment 5 WebKit Commit Bot 2019-11-15 11:50:28 PST
Comment on attachment 383580 [details]
Patch

Clearing flags on attachment: 383580

Committed r252495: <https://trac.webkit.org/changeset/252495>
Comment 6 WebKit Commit Bot 2019-11-15 11:50:29 PST
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-11-15 11:51:24 PST
<rdar://problem/57235434>