RESOLVED FIXED204150
WebDriver: check the frameID parameter before running switch to frame command 
https://bugs.webkit.org/show_bug.cgi?id=204150
Summary WebDriver: check the frameID parameter before running switch to frame command
Carlos Garcia Campos
Reported 2019-11-13 02:54:31 PST
We should check it's either null, a number (unsigned sort) or an object referencing a web element. Several tests are failing: imported/w3c/webdriver/tests/switch_to_frame/switch.py::test_frame_id_invalid_types[foo] imported/w3c/webdriver/tests/switch_to_frame/switch.py::test_frame_id_invalid_types[True] imported/w3c/webdriver/tests/switch_to_frame/switch.py::test_frame_id_invalid_types[value2] imported/w3c/webdriver/tests/switch_to_frame/switch.py::test_frame_id_invalid_types[value3] imported/w3c/webdriver/tests/switch_to_frame/switch.py::test_frame_id_out_of_bounds[-1] imported/w3c/webdriver/tests/switch_to_frame/switch.py::test_frame_id_out_of_bounds[65536]
Attachments
Patch (4.68 KB, patch)
2019-11-13 02:57 PST, Carlos Garcia Campos 		clopez: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2019-11-13 02:57:36 PST
Created attachment 383444 [details] Patch
Carlos Garcia Campos
Comment 2 2019-11-13 06:38:13 PST
Committed r252407: <https://trac.webkit.org/changeset/252407>
Radar WebKit Bug Importer
Comment 3 2019-11-13 06:39:25 PST
<rdar://problem/57152713>
Note You need to log in before you can comment on or make changes to this bug.