Bug 204099 - [LFC] InlineFormattingState::addInlineRun should take a unique_ptr<Display::Run>
Summary: [LFC] InlineFormattingState::addInlineRun should take a unique_ptr<Display::Run>
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-11-11 19:00 PST by zalan
Modified: 2019-11-12 17:08 PST (History)
6 users (show)

See Also:

Attachments
Patch (3.29 KB, patch)
2019-11-11 19:04 PST, zalan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2019-11-11 19:00:40 PST 
instead of a const Display::Run and create a unique_ptr right away.
Comment 1 Radar WebKit Bug Importer 2019-11-11 19:01:31 PST 
<rdar://problem/57102586>
Comment 2 zalan 2019-11-11 19:04:19 PST 
Created attachment 383331 [details]
Patch
Comment 3 WebKit Commit Bot 2019-11-12 17:07:36 PST 
The commit-queue encountered the following flaky tests while processing attachment 383331 [details]:

inspector/model/remote-object-weak-collection.html bug 202932 (authors: drousso@apple.com and joepeck@webkit.org)
The commit-queue is continuing to process your patch.
Comment 4 WebKit Commit Bot 2019-11-12 17:08:15 PST 
Comment on attachment 383331 [details]
Patch

Clearing flags on attachment: 383331

Committed r252380: <https://trac.webkit.org/changeset/252380>
Comment 5 WebKit Commit Bot 2019-11-12 17:08:17 PST 
All reviewed patches have been landed.  Closing bug.