Bug 204093 – Web Inspector: Local Overrides: drop zone overlay doesn't take up the full content area

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

Created attachment 383315 [details]
[Image] Screenshot of issue

.

[Devin Rousso]

Created attachment 383317 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 383317 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383317&action=review

> Source/WebInspectorUI/UserInterface/Views/ImageResourceContentView.css:-38
> -.content-view.resource.image > .drop-zone {
> -    top: calc(var(--navigation-bar-height) - 2px); /* borders */
> -}

I'd expect to keep this offset but not include it if there is no banner. So something like:

    .content-view.resource.image.no-banner > .drop-zone { ... }

[Devin Rousso]

Comment on attachment 383317 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383317&action=review

>> Source/WebInspectorUI/UserInterface/Views/ImageResourceContentView.css:-38
>> -}
> 
> I'd expect to keep this offset but not include it if there is no banner. So something like:
> 
>     .content-view.resource.image.no-banner > .drop-zone { ... }

Ah!  I totally forgot about the banner!  I was wondering why this code existed :P

Good catch!

[Devin Rousso]

Created attachment 383369 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 383369 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 383369 [details]
Patch

Clearing flags on attachment: 383369

Committed r252379: <https://trac.webkit.org/changeset/252379>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/57136479>