Bug 204068 - REGRESSION(r250707): [GTK] UIClient::setWindowFrame only works the first time
Summary: REGRESSION(r250707): [GTK] UIClient::setWindowFrame only works the first time
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk, Regression
Depends on:
Blocks:
 
Reported: 2019-11-11 07:10 PST by Carlos Garcia Campos
Modified: 2019-11-12 00:08 PST (History)
5 users (show)

See Also:


Attachments
Patch (1.83 KB, patch)
2019-11-11 07:11 PST, Carlos Garcia Campos
aperez: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2019-11-11 07:10:22 PST
This is because we are connecting to configure-event of parent window, but not returning FALSE from the callback to propagate the event.
Comment 1 Carlos Garcia Campos 2019-11-11 07:11:26 PST
Created attachment 383267 [details]
Patch
Comment 2 EWS Watchlist 2019-11-11 07:12:22 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Carlos Garcia Campos 2019-11-12 00:08:01 PST
Committed r252355: <https://trac.webkit.org/changeset/252355>