Bug 203871 - [iOS] Scroll position does not get restored when doing a history navigation while the reader view is shown
Summary: [iOS] Scroll position does not get restored when doing a history navigation w...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-11-05 16:46 PST by Chris Dumez
Modified: 2019-11-05 22:42 PST (History)
6 users (show)

See Also:


Attachments
Patch (12.16 KB, patch)
2019-11-05 16:49 PST, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (12.20 KB, patch)
2019-11-05 16:58 PST, Chris Dumez
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-cq-01 for mac-highsierra (3.49 MB, application/zip)
2019-11-05 20:48 PST, WebKit Commit Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2019-11-05 16:46:53 PST
Scroll position does not get restored when doing a history navigation while the reader view is shown.
Comment 1 Chris Dumez 2019-11-05 16:47:29 PST
<rdar://problem/56564603>
Comment 2 Chris Dumez 2019-11-05 16:49:35 PST
Created attachment 382862 [details]
Patch
Comment 3 Chris Dumez 2019-11-05 16:58:54 PST
Created attachment 382865 [details]
Patch
Comment 4 WebKit Commit Bot 2019-11-05 20:48:02 PST
Comment on attachment 382865 [details]
Patch

Rejecting attachment 382865 [details] from commit-queue.

New failing tests:
webgl/1.0.3/conformance/extensions/webgl-draw-buffers.html
Full output: https://webkit-queues.webkit.org/results/13217588
Comment 5 WebKit Commit Bot 2019-11-05 20:48:04 PST
Created attachment 382890 [details]
Archive of layout-test-results from webkit-cq-01 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: webkit-cq-01  Port: mac-highsierra  Platform: Mac OS X 10.13.6
Comment 6 WebKit Commit Bot 2019-11-05 21:31:32 PST
The commit-queue encountered the following flaky tests while processing attachment 382865 [details]:

imported/w3c/web-platform-tests/websockets/bufferedAmount-unchanged-by-sync-xhr.any.worker.html bug 202003 (author: youennf@gmail.com)
webgl/1.0.3/conformance/extensions/webgl-draw-buffers.html bug 203878 (author: mmaxfield@apple.com)
The commit-queue is continuing to process your patch.
Comment 7 WebKit Commit Bot 2019-11-05 21:31:38 PST
The commit-queue encountered the following flaky tests while processing attachment 382865 [details]:

webgl/1.0.3/conformance/extensions/webgl-draw-buffers.html bug 203878 (author: mmaxfield@apple.com)
The commit-queue is continuing to process your patch.
Comment 8 WebKit Commit Bot 2019-11-05 22:41:58 PST
Comment on attachment 382865 [details]
Patch

Clearing flags on attachment: 382865

Committed r252125: <https://trac.webkit.org/changeset/252125>
Comment 9 WebKit Commit Bot 2019-11-05 22:42:00 PST
All reviewed patches have been landed.  Closing bug.