Bug 203842 - Integrate visualViewport's resize event with HTML5 event loop
Summary: Integrate visualViewport's resize event with HTML5 event loop
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks: 202843
  Show dependency tree / graph
 
Reported: 2019-11-04 23:20 PST by Ryosuke Niwa
Modified: 2019-11-05 19:57 PST (History)
8 users (show)

See Also:

Attachments
WIP (2.66 KB, patch)
2019-11-05 15:00 PST, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Patch (7.69 KB, patch)
2019-11-05 16:23 PST, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2019-11-04 23:20:41 PST 
Somehow my patch in https://trac.webkit.org/changeset/251867 didn't include the visual viewport change
unlike the earlier https://trac.webkit.org/changeset/251269

Make visualViewport's resize use HTML5 event loop as well.
Comment 1 Ryosuke Niwa 2019-11-05 15:00:03 PST 
Created attachment 382854 [details]
WIP
Comment 2 Ryosuke Niwa 2019-11-05 16:23:04 PST 
Created attachment 382860 [details]
Patch
Comment 3 Ryosuke Niwa 2019-11-05 17:00:17 PST 
I've manually ran visual viewport tests on iOS (and they pass) since iOS EWS is sick.
Comment 4 Ryosuke Niwa 2019-11-05 19:56:06 PST 
Comment on attachment 382860 [details]
Patch

Clearing flags on attachment: 382860

Committed r252122: <https://trac.webkit.org/changeset/252122>
Comment 5 Ryosuke Niwa 2019-11-05 19:56:08 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-11-05 19:57:18 PST 
<rdar://problem/56930583>