Bug 203812 - [GTK][WPE] Add libfdk-aac-dev to the install-dependencies script
Summary: [GTK][WPE] Add libfdk-aac-dev to the install-dependencies script
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Philippe Normand
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-11-04 08:16 PST by Sergio Villar Senin
Modified: 2019-11-06 02:34 PST (History)
9 users (show)

See Also:

Attachments
Patch (2.48 KB, patch)
2019-11-06 01:14 PST, Philippe Normand 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sergio Villar Senin 2019-11-04 08:16:56 PST 
There are tons of videos in the web that depend on the fdk-aac gst plugin to correctly play audio (see https://bugs.webkit.org/show_bug.cgi?id=201399). However the libfdk-aac-dev is not listed in the install-dependencies script so the gst plugin won't be built in most of the cases.
Comment 1 Philippe Normand 2019-11-06 01:14:39 PST 
Created attachment 382903 [details]
Patch
Comment 2 WebKit Commit Bot 2019-11-06 02:34:25 PST 
Comment on attachment 382903 [details]
Patch

Clearing flags on attachment: 382903

Committed r252135: <https://trac.webkit.org/changeset/252135>
Comment 3 WebKit Commit Bot 2019-11-06 02:34:27 PST 
All reviewed patches have been landed.  Closing bug.