Bug 203706 – Layout test website-data-removal-for-site-navigated-to-with-link-decoration.html is a flaky failure

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Kate Cheney]

website-data-removal-for-site-navigated-to-with-link-decoration.html is a flaky failure

[Radar WebKit Bug Importer]

<rdar://problem/56801615>

[Kate Cheney]

Created attachment 382587 [details]
Patch

[Kate Cheney]

Created attachment 382625 [details]
Patch

[Kate Cheney]

Created attachment 382868 [details]
Patch

[Chris Dumez]

Comment on attachment 382868 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382868&action=review

> Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:230
> +            m_persistentStorage->populateMemoryStoreFromDisk([protectedThis = protectedThis.copyRef(), completionHandler = WTFMove(completionHandler)]() mutable {

WTFMove(protectedThis)

[Kate Cheney]

Created attachment 382878 [details]
Patch

[EWS]

Comment on attachment 382878 [details]
Patch

Rejecting attachment 382878 [details] from commit-queue.

[e-mail] does not have committer permissions according to https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.

[Chris Dumez]

(In reply to ews-feeder from comment #7)
> Comment on attachment 382878 [details]
> Patch
> 
> Rejecting attachment 382878 [details] from commit-queue.
> 
> [e-mail] does not have committer permissions according to
> https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/
> contributors.json.
> 
> - If you do not have committer rights please read
> http://webkit.org/coding/contributing.html for instructions on how to use
> bugzilla flags.
> 
> - If you have committer rights please correct the error in
> Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to
> the file (no review needed).  The commit-queue restarts itself every 2
> hours.  After restart the commit-queue will correctly respect your committer
> rights.

Still not working? You really need to talk to somebody about this...

[WebKit Commit Bot]

Comment on attachment 382878 [details]
Patch

Clearing flags on attachment: 382878

Committed r252123: <https://trac.webkit.org/changeset/252123>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Kate Cheney]

(In reply to Chris Dumez from comment #8)
> (In reply to ews-feeder from comment #7)
> > Comment on attachment 382878 [details]
> > Patch
> > 
> > Rejecting attachment 382878 [details] from commit-queue.
> > 
> > [e-mail] does not have committer permissions according to
> > https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/
> > contributors.json.
> > 
> > - If you do not have committer rights please read
> > http://webkit.org/coding/contributing.html for instructions on how to use
> > bugzilla flags.
> > 
> > - If you have committer rights please correct the error in
> > Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to
> > the file (no review needed).  The commit-queue restarts itself every 2
> > hours.  After restart the commit-queue will correctly respect your committer
> > rights.
> 
> Still not working? You really need to talk to somebody about this...

I know! I was told it was fixed on Friday, this is my first time trying it since then, I just followed up.