RESOLVED FIXED Bug 203703
Fix GTK build after r251886 
https://bugs.webkit.org/show_bug.cgi?id=203703
Summary Fix GTK build after r251886
Tadeu Zagallo
Reported 2019-10-31 16:46:55 PDT
...
Attachments
Patch (1.59 KB, patch)
2019-10-31 16:48 PDT, Tadeu Zagallo 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tadeu Zagallo
Comment 1 2019-10-31 16:48:52 PDT
Created attachment 382520 [details] Patch
Tadeu Zagallo
Comment 2 2019-10-31 16:49:29 PDT
Let's see if EWS is green, or if there are more things to fix.
Mark Lam
Comment 3 2019-10-31 17:01:30 PDT
Comment on attachment 382520 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=382520&action=review > Source/JavaScriptCore/wasm/WasmSlowPaths.cpp:400 > +extern "C" SlowPathReturnType slow_path_wasm_throw_exception(CallFrame* callFrame, const Instruction* pc, Wasm::Instance* instance, Wasm::ExceptionType exceptionType) Don't you also have to do this for slow_path_wasm_popcount and slow_path_wasm_popcount11?
Tadeu Zagallo
Comment 4 2019-10-31 22:04:15 PDT
(In reply to Mark Lam from comment #3) > Comment on attachment 382520 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=382520&action=review > > > Source/JavaScriptCore/wasm/WasmSlowPaths.cpp:400 > > +extern "C" SlowPathReturnType slow_path_wasm_throw_exception(CallFrame* callFrame, const Instruction* pc, Wasm::Instance* instance, Wasm::ExceptionType exceptionType) > > Don't you also have to do this for slow_path_wasm_popcount and > slow_path_wasm_popcount11? Those are already annotated
Yusuke Suzuki
Comment 5 2019-10-31 22:06:40 PDT
Comment on attachment 382520 [details] Patch r=me
Tadeu Zagallo
Comment 6 2019-10-31 22:09:01 PDT
Comment on attachment 382520 [details] Patch Thanks for the review!
WebKit Commit Bot
Comment 7 2019-10-31 22:53:52 PDT
Comment on attachment 382520 [details] Patch Clearing flags on attachment: 382520 Committed r251911: <https://trac.webkit.org/changeset/251911>
WebKit Commit Bot
Comment 8 2019-10-31 22:53:55 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2019-10-31 22:54:14 PDT
<rdar://problem/56807680>
Yusuke Suzuki
Comment 10 2019-10-31 23:34:27 PDT
Committed r251912: <https://trac.webkit.org/changeset/251912>
Note You need to log in before you can comment on or make changes to this bug.