Bug 203703 - Fix GTK build after r251886
Summary: Fix GTK build after r251886
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tadeu Zagallo
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-10-31 16:46 PDT by Tadeu Zagallo
Modified: 2019-10-31 23:34 PDT (History)
8 users (show)

See Also:


Attachments
Patch (1.59 KB, patch)
2019-10-31 16:48 PDT, Tadeu Zagallo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tadeu Zagallo 2019-10-31 16:46:55 PDT
...
Comment 1 Tadeu Zagallo 2019-10-31 16:48:52 PDT
Created attachment 382520 [details]
Patch
Comment 2 Tadeu Zagallo 2019-10-31 16:49:29 PDT
Let's see if EWS is green, or if there are more things to fix.
Comment 3 Mark Lam 2019-10-31 17:01:30 PDT
Comment on attachment 382520 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382520&action=review

> Source/JavaScriptCore/wasm/WasmSlowPaths.cpp:400
> +extern "C" SlowPathReturnType slow_path_wasm_throw_exception(CallFrame* callFrame, const Instruction* pc, Wasm::Instance* instance, Wasm::ExceptionType exceptionType)

Don't you also have to do this for slow_path_wasm_popcount and slow_path_wasm_popcount11?
Comment 4 Tadeu Zagallo 2019-10-31 22:04:15 PDT
(In reply to Mark Lam from comment #3)
> Comment on attachment 382520 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=382520&action=review
> 
> > Source/JavaScriptCore/wasm/WasmSlowPaths.cpp:400
> > +extern "C" SlowPathReturnType slow_path_wasm_throw_exception(CallFrame* callFrame, const Instruction* pc, Wasm::Instance* instance, Wasm::ExceptionType exceptionType)
> 
> Don't you also have to do this for slow_path_wasm_popcount and
> slow_path_wasm_popcount11?

Those are already annotated
Comment 5 Yusuke Suzuki 2019-10-31 22:06:40 PDT
Comment on attachment 382520 [details]
Patch

r=me
Comment 6 Tadeu Zagallo 2019-10-31 22:09:01 PDT
Comment on attachment 382520 [details]
Patch

Thanks for the review!
Comment 7 WebKit Commit Bot 2019-10-31 22:53:52 PDT
Comment on attachment 382520 [details]
Patch

Clearing flags on attachment: 382520

Committed r251911: <https://trac.webkit.org/changeset/251911>
Comment 8 WebKit Commit Bot 2019-10-31 22:53:55 PDT
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2019-10-31 22:54:14 PDT
<rdar://problem/56807680>
Comment 10 Yusuke Suzuki 2019-10-31 23:34:27 PDT
Committed r251912: <https://trac.webkit.org/changeset/251912>