Bug 203461 - REGRESSION(2.27.2): [GTK] Overview item remove button broken
Summary: REGRESSION(2.27.2): [GTK] Overview item remove button broken
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2019-10-26 10:14 PDT by Michael Catanzaro
Modified: 2019-10-30 00:57 PDT (History)
6 users (show)

See Also:

Patch (2.10 KB, patch)
2019-10-29 04:09 PDT, Carlos Garcia Campos
aperez: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2019-10-26 10:14:35 PDT
Since upgrading Tech Preview from 2.26.1 -> 2.27.2, the remove button for about:overview overview items is broken. We see a broken image placeholder instead of the proper remove icon.

Normally I'd check the web inspector for hints, but the web inspector is itself still broken (bug #202321, pending new shared-mime-info release), so no hints.
Comment 1 Carlos Garcia Campos 2019-10-29 04:07:11 PDT
This is a regression of the switch to new custom protocols implementation. Epiphany is passing NULL as content type of ephy-resource requests, in which case we should try to guess the mime type, but we are not doing it.
Comment 2 Carlos Garcia Campos 2019-10-29 04:09:02 PDT
Created attachment 382175 [details]
Comment 3 EWS Watchlist 2019-10-29 04:09:38 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 4 Carlos Garcia Campos 2019-10-30 00:57:10 PDT
Committed r251769: <https://trac.webkit.org/changeset/251769>