Bug 203457 - [LFC][IFC] Completely collapsed runs should not have advance width
Summary: [LFC][IFC] Completely collapsed runs should not have advance width
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-10-26 04:57 PDT by zalan
Modified: 2019-10-26 10:40 PDT (History)
7 users (show)

See Also:

Attachments
Patch (11.65 KB, patch)
2019-10-26 05:03 PDT, zalan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Radar WebKit Bug Importer 2019-10-26 04:57:43 PDT 
<rdar://problem/56645024>
Comment 2 zalan 2019-10-26 05:03:18 PDT 
Created attachment 382011 [details]
Patch
Comment 3 WebKit Commit Bot 2019-10-26 05:53:07 PDT 
Comment on attachment 382011 [details]
Patch

Clearing flags on attachment: 382011

Committed r251633: <https://trac.webkit.org/changeset/251633>
Comment 4 WebKit Commit Bot 2019-10-26 05:53:09 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Geoffrey Garen 2019-10-26 09:38:21 PDT 
Do we have a way to write regression tests for LFC?
Comment 6 zalan 2019-10-26 10:40:05 PDT 
(In reply to Geoffrey Garen from comment #5)
> Do we have a way to write regression tests for LFC?
I periodically update the /Tools/LayoutReloaded/misc/LFC-passing-tests.txt file with newly passing tests and run regression test locally. I've been mostly testing LFC against fast/block and fast/text but I hear WPT has plenty of related tests.