Bug 203343 - [ANGLE] Improve compile-time macOS guards and avoid ObjC if possible
Summary: [ANGLE] Improve compile-time macOS guards and avoid ObjC if possible
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-10-23 15:24 PDT by Dean Jackson
Modified: 2019-10-23 16:38 PDT (History)
6 users (show)

See Also:


Attachments
Patch (83.26 KB, patch)
2019-10-23 15:28 PDT, Dean Jackson
no flags Details | Formatted Diff | Diff
Patch (71.80 KB, patch)
2019-10-23 15:38 PDT, Dean Jackson
no flags Details | Formatted Diff | Diff
Patch (71.80 KB, patch)
2019-10-23 15:44 PDT, Dean Jackson
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2019-10-23 15:24:48 PDT
[ANGLE] Improve compile-time macOS guards and avoid ObjC if possible
Comment 1 Dean Jackson 2019-10-23 15:28:44 PDT
Created attachment 381740 [details]
Patch
Comment 2 Dean Jackson 2019-10-23 15:38:07 PDT
Created attachment 381742 [details]
Patch
Comment 3 EWS Watchlist 2019-10-23 15:39:16 PDT
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
Comment 4 Dean Jackson 2019-10-23 15:44:35 PDT
Created attachment 381744 [details]
Patch
Comment 5 Dean Jackson 2019-10-23 16:38:01 PDT
Committed r251510: <https://trac.webkit.org/changeset/251510>
Comment 6 Radar WebKit Bug Importer 2019-10-23 16:38:16 PDT
<rdar://problem/56560444>