Bug 203086 - Deprecate ActiveDOMObject::canSuspendForDocumentSuspension()
Summary: Deprecate ActiveDOMObject::canSuspendForDocumentSuspension()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 202293
  Show dependency treegraph
 
Reported: 2019-10-17 09:20 PDT by Chris Dumez
Modified: 2019-10-17 11:19 PDT (History)
32 users (show)

See Also:


Attachments
Patch (88.14 KB, patch)
2019-10-17 09:24 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2019-10-17 09:20:30 PDT
Deprecate ActiveDOMObject::canSuspendForDocumentSuspension() as it is no longer acceptable to prevent a page from entering the back/forward cache.
Comment 1 Chris Dumez 2019-10-17 09:24:48 PDT
Created attachment 381196 [details]
Patch
Comment 2 Antti Koivisto 2019-10-17 09:38:07 PDT
Comment on attachment 381196 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381196&action=review

> Source/WebCore/Modules/encryptedmedia/MediaKeySession.cpp:746
> +// FIXME: This should never prevent entering the back/forward cache.

It might be good to file and link bugs for all these.
Comment 3 Chris Dumez 2019-10-17 09:39:08 PDT
(In reply to Antti Koivisto from comment #2)
> Comment on attachment 381196 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=381196&action=review
> 
> > Source/WebCore/Modules/encryptedmedia/MediaKeySession.cpp:746
> > +// FIXME: This should never prevent entering the back/forward cache.
> 
> It might be good to file and link bugs for all these.

Agreed, will do this next.
Comment 4 Chris Dumez 2019-10-17 10:00:32 PDT
Comment on attachment 381196 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381196&action=review

>>> Source/WebCore/Modules/encryptedmedia/MediaKeySession.cpp:746
>>> +// FIXME: This should never prevent entering the back/forward cache.
>> 
>> It might be good to file and link bugs for all these.
> 
> Agreed, will do this next.

Ok, I mass-filed a bug for each remaining override and related all the bugs to https://bugs.webkit.org/show_bug.cgi?id=202293.
Comment 5 Geoffrey Garen 2019-10-17 10:33:30 PDT
Comment on attachment 381196 [details]
Patch

r=me
Comment 6 Chris Dumez 2019-10-17 10:35:34 PDT
Comment on attachment 381196 [details]
Patch

Clearing flags on attachment: 381196

Committed r251244: <https://trac.webkit.org/changeset/251244>
Comment 7 Chris Dumez 2019-10-17 10:35:36 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2019-10-17 10:36:12 PDT
<rdar://problem/56375664>