Bug 202887 - Fix the spelling of ThreeDDarkDhasowColor and unwrap the ThemeType enums
Summary: Fix the spelling of ThreeDDarkDhasowColor and unwrap the ThemeType enums
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-10-12 16:42 PDT by Simon Fraser (smfr)
Modified: 2019-10-15 14:57 PDT (History)
8 users (show)

See Also:

Attachments
Patch (6.19 KB, patch)
2019-10-12 16:42 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Patch (6.19 KB, patch)
2019-10-12 17:45 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2019-10-12 16:42:13 PDT 
Fix the spelling of ThreeDDarkDhasowColor and unwrap the ThemeType enums
Comment 1 Simon Fraser (smfr) 2019-10-12 16:42:48 PDT 
Created attachment 380836 [details]
Patch
Comment 2 Wenson Hsieh 2019-10-12 17:03:51 PDT 
Comment on attachment 380836 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380836&action=review

rs=me

> Source/WebCore/platform/ThemeTypes.h:152
> +    ThreeDShadowCLor,

It seems like the “CLor” at the end is not intended either.
Comment 3 Simon Fraser (smfr) 2019-10-12 17:45:39 PDT 
Created attachment 380840 [details]
Patch
Comment 4 WebKit Commit Bot 2019-10-12 18:14:31 PDT 
Comment on attachment 380840 [details]
Patch

Clearing flags on attachment: 380840

Committed r251054: <https://trac.webkit.org/changeset/251054>
Comment 5 WebKit Commit Bot 2019-10-12 18:14:33 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Ling Ho 2019-10-15 14:57:13 PDT 
<rdar://problem/56224287>