Bug 202680 - Web Inspector: Canvas: make it more obvious that the cards in the overview are clickable
Summary: Web Inspector: Canvas: make it more obvious that the cards in the overview ar...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-10-07 21:01 PDT by Devin Rousso
Modified: 2019-10-08 14:10 PDT (History)
6 users (show)

See Also:


Attachments
Patch (3.89 KB, patch)
2019-10-07 21:27 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff
[Video] After Patch is applied (3.20 MB, video/quicktime)
2019-10-07 21:28 PDT, Devin Rousso
no flags Details
Patch (3.90 KB, patch)
2019-10-08 12:55 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2019-10-07 21:01:35 PDT
The only thing that changes on `:hover` is the cursor.  We should also consider slightly darkening the background, like many other buttons-esque things.
Comment 1 Devin Rousso 2019-10-07 21:27:51 PDT
Created attachment 380395 [details]
Patch
Comment 2 Devin Rousso 2019-10-07 21:28:14 PDT
Created attachment 380396 [details]
[Video] After Patch is applied
Comment 3 Matt Baker 2019-10-08 11:58:41 PDT
Comment on attachment 380395 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380395&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/CanvasOverviewContentView.css:40
> +

Extra blank line.
Comment 4 Devin Rousso 2019-10-08 12:55:28 PDT
Created attachment 380453 [details]
Patch
Comment 5 WebKit Commit Bot 2019-10-08 14:09:25 PDT
Comment on attachment 380453 [details]
Patch

Clearing flags on attachment: 380453

Committed r250859: <https://trac.webkit.org/changeset/250859>
Comment 6 WebKit Commit Bot 2019-10-08 14:09:26 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-10-08 14:10:21 PDT
<rdar://problem/56088180>