Bug 202632 - [CSS Shadow Parts] Implement style invalidation
Summary: [CSS Shadow Parts] Implement style invalidation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: 149443
  Show dependency tree / graph
 
Reported: 2019-10-07 05:29 PDT by Antti Koivisto
Modified: 2019-10-08 05:23 PDT (History)
13 users (show)

See Also:

Attachments
patch (15.00 KB, patch)
2019-10-07 05:49 PDT, Antti Koivisto 		rniwa: review+
Details | Formatted Diff | Diff
patch (21.22 KB, patch)
2019-10-08 03:49 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2019-10-07 05:29:03 PDT 
::part() style should be invalidated on DOM mutations.
Comment 1 Antti Koivisto 2019-10-07 05:49:21 PDT 
Created attachment 380316 [details]
patch
Comment 2 Ryosuke Niwa 2019-10-07 13:49:07 PDT 
Comment on attachment 380316 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380316&action=review

> LayoutTests/ChangeLog:10
> +        * fast/css/shadow-parts/invalidation-class-descendant-combinator-expected.txt: Added.

Can we also add tests for sibling combinators (+ & ~) as well as pseudo class like :hover and :active?
Comment 3 Antti Koivisto 2019-10-08 03:49:15 PDT 
Created attachment 380418 [details]
patch
Comment 4 Antti Koivisto 2019-10-08 04:37:58 PDT 
> Can we also add tests for sibling combinators (+ & ~) as well as pseudo
> class like :hover and :active?

Added sibling combinator tests in this patch.
Comment 5 WebKit Commit Bot 2019-10-08 05:22:28 PDT 
Comment on attachment 380418 [details]
patch

Clearing flags on attachment: 380418

Committed r250821: <https://trac.webkit.org/changeset/250821>
Comment 6 WebKit Commit Bot 2019-10-08 05:22:30 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-10-08 05:23:14 PDT 
<rdar://problem/56071065>