Bug 202554 - Fix testmasm failure on ASan builds.
Summary: Fix testmasm failure on ASan builds.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-10-03 17:55 PDT by Mark Lam
Modified: 2019-10-03 18:27 PDT (History)
8 users (show)

See Also:

Attachments
proposed patch. (2.43 KB, patch)
2019-10-03 18:01 PDT, Mark Lam 		no flags Details | Formatted Diff | Diff
proposed patch. (2.58 KB, patch)
2019-10-03 18:03 PDT, Mark Lam 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2019-10-03 17:55:49 PDT 
Gigacage is disabled on ASan builds.  So testmasm is sad.  Make the relevant test bail gracefully if Gigacage should be disabled.
Comment 1 Mark Lam 2019-10-03 18:01:54 PDT 
Created attachment 380173 [details]
proposed patch.
Comment 2 Mark Lam 2019-10-03 18:03:04 PDT 
Created attachment 380174 [details]
proposed patch.
Comment 3 Yusuke Suzuki 2019-10-03 18:06:24 PDT 
Comment on attachment 380174 [details]
proposed patch.

r=me
Comment 4 WebKit Commit Bot 2019-10-03 18:26:33 PDT 
Comment on attachment 380174 [details]
proposed patch.

Clearing flags on attachment: 380174

Committed r250695: <https://trac.webkit.org/changeset/250695>
Comment 5 WebKit Commit Bot 2019-10-03 18:26:34 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-10-03 18:27:18 PDT 
<rdar://problem/55969676>