Bug 202507 - [WebAuthn] Implement dummy _WKWebAuthenticationPanel SPI
Summary: [WebAuthn] Implement dummy _WKWebAuthenticationPanel SPI
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jiewen Tan
URL:
Keywords: InRadar
Depends on:
Blocks: 181943
  Show dependency tree / graph
 
Reported: 2019-10-02 18:15 PDT by Jiewen Tan
Modified: 2019-10-03 11:30 PDT (History)
7 users (show)

See Also:

Attachments
Patch (17.60 KB, patch)
2019-10-02 18:35 PDT, Jiewen Tan 		no flags Details | Formatted Diff | Diff
Patch (16.98 KB, patch)
2019-10-03 02:04 PDT, Jiewen Tan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jiewen Tan 2019-10-02 18:15:45 PDT 
Implement dummy _WKWebAuthenticationPanel SPI.
Comment 1 Jiewen Tan 2019-10-02 18:16:00 PDT 
<rdar://problem/55918793>
Comment 2 Jiewen Tan 2019-10-02 18:35:47 PDT 
Created attachment 380075 [details]
Patch
Comment 3 Jiewen Tan 2019-10-03 02:04:28 PDT 
Created attachment 380092 [details]
Patch
Comment 4 Brent Fulgham 2019-10-03 09:14:29 PDT 
ERROR: Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.h:29:  Alphabetical sorting problem.  [build/include_order] [4]
Comment 5 WebKit Commit Bot 2019-10-03 09:48:56 PDT 
Comment on attachment 380092 [details]
Patch

Clearing flags on attachment: 380092

Committed r250658: <https://trac.webkit.org/changeset/250658>
Comment 6 WebKit Commit Bot 2019-10-03 09:48:58 PDT 
All reviewed patches have been landed.  Closing bug.