Bug 202273 - TestWebKitAPI.WebKit.ReloadWithDifferingInitialScale is failing consistently
Summary: TestWebKitAPI.WebKit.ReloadWithDifferingInitialScale is failing consistently
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-09-26 09:28 PDT by Aakash Jain
Modified: 2019-09-26 11:52 PDT (History)
7 users (show)

See Also:


Attachments
Patch (2.29 KB, patch)
2019-09-26 09:55 PDT, Wenson Hsieh
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2019-09-26 09:28:13 PDT
TestWebKitAPI.WebKit.ReloadWithDifferingInitialScale has started to fail consistently (both on EWS and build.webkit.org) since yesterday.

e..g: 
https://ews-build.webkit.org/#/builders/9/builds/9058

https://build.webkit.org/builders/Apple%20iOS%2013%20Simulator%20Debug%20WK2%20%28Tests%29/builds/136/steps/run-api-tests/logs/stdio
Comment 2 Wenson Hsieh 2019-09-26 09:48:04 PDT
Oops. I think this is behaving as expected after r250361; the test just needs to be tweaked.
Comment 3 Wenson Hsieh 2019-09-26 09:55:56 PDT
Created attachment 379652 [details]
Patch
Comment 4 Wenson Hsieh 2019-09-26 10:03:35 PDT
<rdar://problem/52906640>
Comment 5 Wenson Hsieh 2019-09-26 10:45:27 PDT
Comment on attachment 379652 [details]
Patch

Thanks for the review!
Comment 6 WebKit Commit Bot 2019-09-26 11:52:19 PDT
Comment on attachment 379652 [details]
Patch

Clearing flags on attachment: 379652

Committed r250391: <https://trac.webkit.org/changeset/250391>
Comment 7 WebKit Commit Bot 2019-09-26 11:52:21 PDT
All reviewed patches have been landed.  Closing bug.