RESOLVED FIXED 202223
[ews] JSC queues should run or skip tests based on runTests key from config.json 
https://bugs.webkit.org/show_bug.cgi?id=202223
Summary [ews] JSC queues should run or skip tests based on runTests key from config.json
Aakash Jain
Reported 2019-09-25 12:44:58 PDT
Few JSC queues should be running tests and few shouldn't be. We should add 'runTests' key in config.json and JSCTestsFactory should skip or add tests based on that key.
Attachments
Patch (4.33 KB, patch)
2019-09-25 12:50 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2019-09-25 12:50:06 PDT
Created attachment 379574 [details] Patch
Aakash Jain
Comment 2 2019-09-25 12:53:36 PDT
Tested on UAT instance by manually modifying 'runTests' key in config.json "runTests": "true" => https://ews-build.webkit-uat.org/#/builders/17/builds/4147 "runTests": "false" => https://ews-build.webkit-uat.org/#/builders/17/builds/4148
Jonathan Bedard
Comment 3 2019-09-25 13:02:43 PDT
Comment on attachment 379574 [details] Patch Code looks good: A higher level question. What are we using this for? Do we have a circumstance where we would like to compile, but not test, JavaScriptCore?
Aakash Jain
Comment 4 2019-09-25 13:09:33 PDT
(In reply to Jonathan Bedard from comment #3) > What are we using this for? Do we have a circumstance where we would like to compile, but not test, JavaScriptCore? Yes, this is for 'JSC i386 EWS' which I will be moving from old to new EWS soon. https://trac.webkit.org/browser/webkit/trunk/Tools/Scripts/webkitpy/common/config/ews.json#L55
WebKit Commit Bot
Comment 5 2019-09-25 13:56:22 PDT
Comment on attachment 379574 [details] Patch Clearing flags on attachment: 379574 Committed r250356: <https://trac.webkit.org/changeset/250356>
WebKit Commit Bot
Comment 6 2019-09-25 13:56:24 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2019-09-25 13:57:23 PDT
<rdar://problem/55717576>
Note You need to log in before you can comment on or make changes to this bug.