Bug 202147 - [Cocoa] Regression(r212041) Safari adds a .dms extension automatically when downloading binaries with no extension
Summary: [Cocoa] Regression(r212041) Safari adds a .dms extension automatically when d...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 168077
  Show dependency treegraph
 
Reported: 2019-09-24 09:44 PDT by Chris Dumez
Modified: 2019-09-25 16:47 PDT (History)
7 users (show)

See Also:


Attachments
Patch (6.62 KB, patch)
2019-09-24 09:46 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (11.93 KB, patch)
2019-09-24 12:30 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (12.27 KB, patch)
2019-09-24 13:05 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (20.78 KB, patch)
2019-09-24 13:39 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (14.51 KB, patch)
2019-09-24 14:33 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2019-09-24 09:44:32 PDT
We should not be adding file extensions to suggested filenames on platforms that do not require them to infer file type:
- https://html.spec.whatwg.org/#as-a-download (step 15)
Comment 1 Chris Dumez 2019-09-24 09:44:47 PDT
<rdar://problem/54886021>
Comment 2 Chris Dumez 2019-09-24 09:46:46 PDT
Created attachment 379458 [details]
Patch
Comment 3 Chris Dumez 2019-09-24 10:57:28 PDT
Discussed it with Alexey offline and he has a better proposal. Will tweak the patch accordingly.
Comment 4 Chris Dumez 2019-09-24 12:30:47 PDT
Created attachment 379467 [details]
Patch
Comment 5 Chris Dumez 2019-09-24 13:05:22 PDT
Created attachment 379475 [details]
Patch
Comment 6 Chris Dumez 2019-09-24 13:39:25 PDT
Created attachment 379484 [details]
Patch
Comment 7 Chris Dumez 2019-09-24 14:33:27 PDT
Created attachment 379494 [details]
Patch
Comment 8 WebKit Commit Bot 2019-09-25 16:47:54 PDT
Comment on attachment 379494 [details]
Patch

Clearing flags on attachment: 379494

Committed r250369: <https://trac.webkit.org/changeset/250369>
Comment 9 WebKit Commit Bot 2019-09-25 16:47:56 PDT
All reviewed patches have been landed.  Closing bug.