Bug 201933 – [LFC] Introduce UsedVerticalValues::Constraints

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[zalan]

ssia

[Radar WebKit Bug Importer]

<rdar://problem/55487485>

[zalan]

Created attachment 379059 [details]
Patch

[Antti Koivisto]

Comment on attachment 379059 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379059&action=review

> Source/WebCore/layout/LayoutUnits.h:197
> +    explicit UsedVerticalValues(Constraints constraints)
> +        : constraints(constraints)
> +    {
> +    }
> +
> +    explicit UsedVerticalValues(Constraints constraints, Optional<LayoutUnit> height)
> +        : constraints(constraints)
> +        , height(height)
> +    {
> +    }

You could just have one of these :

UsedVerticalValues(Constraints constraints, Optional<LayoutUnit> height = { })

[zalan]

(In reply to Antti Koivisto from comment #3)
> Comment on attachment 379059 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=379059&action=review
> 
> > Source/WebCore/layout/LayoutUnits.h:197
> > +    explicit UsedVerticalValues(Constraints constraints)
> > +        : constraints(constraints)
> > +    {
> > +    }
> > +
> > +    explicit UsedVerticalValues(Constraints constraints, Optional<LayoutUnit> height)
> > +        : constraints(constraints)
> > +        , height(height)
> > +    {
> > +    }
> 
> You could just have one of these :
> 
> UsedVerticalValues(Constraints constraints, Optional<LayoutUnit> height = {
> })
Indeed.

[zalan]

Created attachment 379072 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 379072 [details]
Patch

Clearing flags on attachment: 379072

Committed r250056: <https://trac.webkit.org/changeset/250056>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.