Bug 201922 - WebStorageNamespaceProvider / StorageNamespaceImpl no longer need SessionIDs
Summary: WebStorageNamespaceProvider / StorageNamespaceImpl no longer need SessionIDs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-09-18 10:59 PDT by Chris Dumez
Modified: 2019-09-24 11:40 PDT (History)
16 users (show)

See Also:

Attachments
Patch (13.43 KB, patch)
2019-09-18 11:00 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (1.66 KB, patch)
2019-09-19 13:43 PDT, Yury Semikhatsky 		no flags Details | Formatted Diff | Diff
Patch (20.16 KB, text/plain)
2019-09-24 11:39 PDT, Yury Semikhatsky 		no flags Details
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2019-09-18 10:59:24 PDT 
WebStorageNamespaceProvider / StorageNamespaceImpl no longer need SessionIDs, now that we have a single session per WebProcess.
Comment 1 Chris Dumez 2019-09-18 11:00:18 PDT 
Created attachment 379049 [details]
Patch
Comment 2 Chris Dumez 2019-09-18 19:30:24 PDT 
This patch is ready for review.
Comment 3 Geoffrey Garen 2019-09-18 20:03:57 PDT 
Comment on attachment 379049 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2019-09-18 21:19:05 PDT 
Comment on attachment 379049 [details]
Patch

Clearing flags on attachment: 379049

Committed r250083: <https://trac.webkit.org/changeset/250083>
Comment 5 WebKit Commit Bot 2019-09-18 21:19:07 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-09-18 21:20:19 PDT 
<rdar://problem/55505906>
Comment 7 Yury Semikhatsky 2019-09-19 13:43:38 PDT 
Reopening to attach new patch.
Comment 8 Yury Semikhatsky 2019-09-19 13:43:39 PDT 
Created attachment 379160 [details]
Patch
Comment 9 Chris Dumez 2019-09-19 13:56:11 PDT 
Comment on attachment 379160 [details]
Patch

Thanks.
Comment 10 WebKit Commit Bot 2019-09-19 14:46:10 PDT 
Comment on attachment 379160 [details]
Patch

Clearing flags on attachment: 379160

Committed r250106: <https://trac.webkit.org/changeset/250106>
Comment 11 WebKit Commit Bot 2019-09-19 14:46:11 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 12 Yury Semikhatsky 2019-09-24 11:39:36 PDT 
Reopening to attach new patch.
Comment 13 Yury Semikhatsky 2019-09-24 11:39:37 PDT 
Created attachment 379461 [details]
Patch
Comment 14 EWS Watchlist 2019-09-24 11:40:35 PDT 
This patch modifies the inspector protocol. Please ensure that any frontend changes appropriately use feature checks for new protocol features.
Comment 15 Yury Semikhatsky 2019-09-24 11:40:50 PDT 
Comment on attachment 379461 [details]
Patch

Wrong but number, sorry for the noise.