RESOLVED FIXED201697
Re-sync dom web-platform-tests from upstream 
https://bugs.webkit.org/show_bug.cgi?id=201697
Summary Re-sync dom web-platform-tests from upstream
Chris Dumez
Reported 2019-09-11 14:02:22 PDT
Re-sync dom web-platform-tests from upstream.
Attachments
Patch (648.70 KB, patch)
2019-09-11 14:05 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (647.41 KB, patch)
2019-09-11 15:40 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (670.84 KB, patch)
2019-09-12 08:23 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2019-09-11 14:05:01 PDT
Created attachment 378577 [details] Patch
Chris Dumez
Comment 2 2019-09-11 15:40:32 PDT
Created attachment 378583 [details] Patch
youenn fablet
Comment 3 2019-09-12 01:32:28 PDT
Comment on attachment 378583 [details] Patch Some tests need iOS wk2 expected.txt file updates. View in context: https://bugs.webkit.org/attachment.cgi?id=378583&action=review > LayoutTests/imported/w3c/web-platform-tests/dom/idlharness.any.html:1 > +<!-- This file is required for WebKit test infrastructure to run the templated test --> Let's remove that file or skip the test given the above error message. > LayoutTests/imported/w3c/web-platform-tests/dom/idlharness.any.js:1 > +// META: global=!window,worker I'll try to check whether we are expected to look at the META tag instead of .any.js to create window/worker html dummy files by w3c importer. Or maybe it should be moved to ildharness.worker.js
youenn fablet
Comment 4 2019-09-12 01:43:04 PDT
(In reply to youenn fablet from comment #3) > Comment on attachment 378583 [details] > Patch > > Some tests need iOS wk2 expected.txt file updates. > > View in context: > https://bugs.webkit.org/attachment.cgi?id=378583&action=review > > > LayoutTests/imported/w3c/web-platform-tests/dom/idlharness.any.html:1 > > +<!-- This file is required for WebKit test infrastructure to run the templated test --> > > Let's remove that file or skip the test given the above error message. > > > LayoutTests/imported/w3c/web-platform-tests/dom/idlharness.any.js:1 > > +// META: global=!window,worker > > I'll try to check whether we are expected to look at the META tag instead of > .any.js to create window/worker html dummy files by w3c importer. > Or maybe it should be moved to ildharness.worker.js Filed https://bugs.webkit.org/show_bug.cgi?id=201718
youenn fablet
Comment 5 2019-09-12 01:43:32 PDT
> > Let's remove that file or skip the test given the above error message. We should remove LayoutTests/imported/w3c/web-platform-tests/dom/idlharness.any.html
Chris Dumez
Comment 6 2019-09-12 08:23:20 PDT
Created attachment 378646 [details] Patch
Chris Dumez
Comment 7 2019-09-12 09:39:07 PDT
Comment on attachment 378646 [details] Patch Clearing flags on attachment: 378646 Committed r249811: <https://trac.webkit.org/changeset/249811>
Chris Dumez
Comment 8 2019-09-12 09:39:08 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2019-09-12 09:40:23 PDT
<rdar://problem/55304936>
Note You need to log in before you can comment on or make changes to this bug.