Bug 201669 - Web Inspector: Elements: don't show Changes panel when selecting text node
Summary: Web Inspector: Elements: don't show Changes panel when selecting text node
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nikita Vasilyev
URL:
Keywords: InRadar
: 201039 (view as bug list)
Depends on:
Blocks:
 
Reported: 2019-09-10 17:52 PDT by Nikita Vasilyev
Modified: 2019-09-12 12:27 PDT (History)
5 users (show)

See Also:


Attachments
Patch (1.94 KB, patch)
2019-09-10 18:02 PDT, Nikita Vasilyev
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Vasilyev 2019-09-10 17:52:33 PDT
Currently...
When "Show only for selected node" setting is enabled, Changes panel is NOT shown for text nodes.
When the setting is disabled, Changes panel always shown.

I suggest to never show Changes panel for text nodes, regardless of the setting.
Comment 1 Nikita Vasilyev 2019-09-10 18:02:21 PDT
Created attachment 378519 [details]
Patch
Comment 2 Joseph Pecoraro 2019-09-11 17:22:35 PDT
Comment on attachment 378519 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2019-09-11 18:06:51 PDT
Comment on attachment 378519 [details]
Patch

Clearing flags on attachment: 378519

Committed r249788: <https://trac.webkit.org/changeset/249788>
Comment 4 WebKit Commit Bot 2019-09-11 18:06:53 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2019-09-11 18:07:17 PDT
<rdar://problem/55285036>
Comment 6 Nikita Vasilyev 2019-09-12 12:27:04 PDT
*** Bug 201039 has been marked as a duplicate of this bug. ***