Bug 201619 - Clarify some macCatalyst feature flags
Summary: Clarify some macCatalyst feature flags
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-09-09 16:40 PDT by Tim Horton
Modified: 2019-09-09 18:01 PDT (History)
11 users (show)

See Also:


Attachments
Patch (8.70 KB, patch)
2019-09-09 16:40 PDT, Tim Horton
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2019-09-09 16:40:32 PDT
Clarify some macCatalyst feature flags
Comment 1 Tim Horton 2019-09-09 16:40:55 PDT
Created attachment 378416 [details]
Patch
Comment 2 Tim Horton 2019-09-09 16:40:57 PDT
<rdar://problem/54615618>
Comment 3 Megan Gardner 2019-09-09 16:45:49 PDT
Comment on attachment 378416 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=378416&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:7530
>  

Why split this? Seems like you could just not have either the above or the below line and it work the same.
Comment 4 Tim Horton 2019-09-09 16:47:10 PDT
Comment on attachment 378416 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=378416&action=review

>> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:7530
>>  
> 
> Why split this? Seems like you could just not have either the above or the below line and it work the same.

Nah, you just can't see what's happening because of the diff :) This is a few thousand lines below the previous hunk. Hit "show all"
Comment 5 Megan Gardner 2019-09-09 16:49:22 PDT
Comment on attachment 378416 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=378416&action=review

>>> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:7530
>>>  
>> 
>> Why split this? Seems like you could just not have either the above or the below line and it work the same.
> 
> Nah, you just can't see what's happening because of the diff :) This is a few thousand lines below the previous hunk. Hit "show all"

I see it now, I retract my statement.
Comment 6 WebKit Commit Bot 2019-09-09 18:01:52 PDT
Comment on attachment 378416 [details]
Patch

Clearing flags on attachment: 378416

Committed r249681: <https://trac.webkit.org/changeset/249681>
Comment 7 WebKit Commit Bot 2019-09-09 18:01:53 PDT
All reviewed patches have been landed.  Closing bug.