RESOLVED FIXED 201619
Clarify some macCatalyst feature flags 
https://bugs.webkit.org/show_bug.cgi?id=201619
Summary Clarify some macCatalyst feature flags
Tim Horton
Reported 2019-09-09 16:40:32 PDT
Clarify some macCatalyst feature flags
Attachments
Patch (8.70 KB, patch)
2019-09-09 16:40 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2019-09-09 16:40:55 PDT
Created attachment 378416 [details] Patch
Tim Horton
Comment 2 2019-09-09 16:40:57 PDT
<rdar://problem/54615618>
Megan Gardner
Comment 3 2019-09-09 16:45:49 PDT
Comment on attachment 378416 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=378416&action=review > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:7530 > Why split this? Seems like you could just not have either the above or the below line and it work the same.
Tim Horton
Comment 4 2019-09-09 16:47:10 PDT
Comment on attachment 378416 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=378416&action=review >> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:7530 >> > > Why split this? Seems like you could just not have either the above or the below line and it work the same. Nah, you just can't see what's happening because of the diff :) This is a few thousand lines below the previous hunk. Hit "show all"
Megan Gardner
Comment 5 2019-09-09 16:49:22 PDT
Comment on attachment 378416 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=378416&action=review >>> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:7530 >>> >> >> Why split this? Seems like you could just not have either the above or the below line and it work the same. > > Nah, you just can't see what's happening because of the diff :) This is a few thousand lines below the previous hunk. Hit "show all" I see it now, I retract my statement.
WebKit Commit Bot
Comment 6 2019-09-09 18:01:52 PDT
Comment on attachment 378416 [details] Patch Clearing flags on attachment: 378416 Committed r249681: <https://trac.webkit.org/changeset/249681>
WebKit Commit Bot
Comment 7 2019-09-09 18:01:53 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.