Bug 201604 - Ensure tests for legacy features are in LayoutTests/mathml
Summary: Ensure tests for legacy features are in LayoutTests/mathml
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: MathML (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Frédéric Wang (:fredw)
URL:
Keywords: InRadar
Depends on:
Blocks: 201603
  Show dependency tree / graph
 
Reported: 2019-09-09 08:57 PDT by Frédéric Wang (:fredw)
Modified: 2019-09-10 07:46 PDT (History)
5 users (show)

See Also:

Attachments
Patch (42.81 KB, patch)
2019-09-09 09:55 PDT, Frédéric Wang (:fredw) 		ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews212 for win-future (13.90 MB, application/zip)
2019-09-09 11:19 PDT, EWS Watchlist 		no flags Details
Patch (43.80 KB, patch)
2019-09-09 20:22 PDT, Frédéric Wang (:fredw) 		rbuis: review+
Details | Formatted Diff | Diff
Patch for landing (43.89 KB, patch)
2019-09-10 07:00 PDT, Frédéric Wang (:fredw) 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Frédéric Wang (:fredw) 2019-09-09 08:57:25 PDT 
Some of them will be removed in 201603 instead checking that legacy features are not supported. Let's keep them in LayoutTests/mathml
Comment 1 Frédéric Wang (:fredw) 2019-09-09 09:55:53 PDT 
Created attachment 378376 [details]
Patch
Comment 2 EWS Watchlist 2019-09-09 11:19:17 PDT 
Comment on attachment 378376 [details]
Patch

Attachment 378376 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/13017160

New failing tests:
mathml/non-core/lengths-3.html
mathml/non-core/lengths-1.html
Comment 3 EWS Watchlist 2019-09-09 11:19:19 PDT 
Created attachment 378389 [details]
Archive of layout-test-results from ews212 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews212  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Comment 4 Frédéric Wang (:fredw) 2019-09-09 20:22:31 PDT 
Created attachment 378438 [details]
Patch
Comment 5 Rob Buis 2019-09-10 03:48:05 PDT 
Comment on attachment 378438 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=378438&action=review

> LayoutTests/ChangeLog:11
> +        Reviewed by NOBODY (OOPS!).

This should go up.
Comment 6 Frédéric Wang (:fredw) 2019-09-10 07:00:27 PDT 
Created attachment 378460 [details]
Patch for landing
Comment 7 WebKit Commit Bot 2019-09-10 07:45:48 PDT 
Comment on attachment 378460 [details]
Patch for landing

Clearing flags on attachment: 378460

Committed r249713: <https://trac.webkit.org/changeset/249713>
Comment 8 WebKit Commit Bot 2019-09-10 07:45:49 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2019-09-10 07:46:24 PDT 
<rdar://problem/55222023>