Bug 201433 – [EWS] Watchlist doesn't work sometimes

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Aakash Jain]

Watchlist doesn't work sometimes. For example https://ews-build.webkit.org/#/builders/21/builds/434 says:
Result of watchlist: cc "[e-mail], [e-mail], [e-mail], [e-mail], [e-mail]" messages ""

However those people weren't cc'ed on the corresponding bug https://bugs.webkit.org/show_bug.cgi?id=201399

I believe this issue has been happening for a long time (with old EWS as well), but is more visible in new EWS.

[Radar WebKit Bug Importer]

<rdar://problem/55027571>

[Aakash Jain]

Watchlist worked fine in https://ews-build.webkit.org/#/builders/21/builds/709 for https://bugs.webkit.org/show_activity.cgi?id=201548

[Aakash Jain]

This is because of email addresses which aren't associated with any Bugzilla account. e.g.: in above failure case, [e-mail] isn't associated with bugzilla account, email associated with bugzilla account for that person is [e-mail]

[Aakash Jain]

Here are the old emails in watchlist file, and corresponding new emails associated with Bugzilla account:

[e-mail] => [e-mail]
[e-mail] => [e-mail]
[e-mail] => [e-mail]
[e-mail] => [e-mail],
[e-mail] => [e-mail],
[e-mail] => [e-mail],
[e-mail] => [e-mail]

[Aakash Jain]

Created attachment 378415 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 378415 [details]
Patch

Clearing flags on attachment: 378415

Committed r249687: <https://trac.webkit.org/changeset/249687>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Takashi Toyoshima]

Thanks for the fix.

fyi, gmail based mail accounts can use a suffix starting with '+', and mail servers just ignore that suffix parts to receive mails. Some chromium members have used '+watchlist'-like suffix for moving received mails to the preferred folder automatically. But it seems this approach has not worked with bugzilla account checks.

So if you find a [e-mail], just renaming to [e-mail] will work, fyi.

[Aakash Jain]

(In reply to Takashi Toyoshima from comment #8)
> Thanks for the fix.
> 
> So if you find a [e-mail], just renaming to [e-mail] will work, fyi.
Thanks for the note. I have cleaned up the list in the above commit and now the only email with that pattern is [e-mail]. It seems like that user have created a bugzilla account explicitly using [e-mail], and it seems to work with EWS (e.g.: https://bugs.webkit.org/show_activity.cgi?id=201663)

[Aakash Jain]

(In reply to WebKit Commit Bot from comment #6)
> Committed r249687: <https://trac.webkit.org/changeset/249687>

Note that this commit simply fixes the email addresses. This problem can happen again if somebody moves the email associated with Bugzilla account, and not update the email in watchlist.

Long-term fix would be to improve the tooling itself.